Bug 207059
| Summary: | math/pdal: Update to 1.1.0 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Marakasov <amdmi3> | ||||||
| Component: | Individual Port(s) | Assignee: | Raphael Kubo da Costa <rakuco> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | lbartoletti, pi, rakuco | ||||||
| Priority: | --- | Keywords: | patch-ready | ||||||
| Version: | Latest | Flags: | rakuco:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://wiki.freebsd.org/BoostPortingProject/1.55-to-1.60 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 199601 | ||||||||
| Attachments: |
|
||||||||
|
Description
Dmitry Marakasov
2016-02-09 14:57:26 UTC
(see https://wiki.freebsd.org/BoostPortingProject/1.55-to-1.60 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199601 ) Created attachment 167742 [details]
Update pdal to 1.1.0
Hello, Can you check if it's ok with this patch? Thanks. Testbuild on 9.3a fails, see http://people.freebsd.org/~pi/logs/math__pdal-93a-1457284628.txt 11a, 10.2a look fine, 10.2i still running. 9.3 is failing because the port uses headers not present in base's libstdc++. Try USES=compiler:c++11-lib instead. While here, I think files/patch-apps_CMakeLists.txt can be replaced by USES=pathfix. I tried to build it on 9.3a with your suggested changes, fails to build in poudriere, see http://people.freebsd.org/~pi/logs/math__pdal-93a Any ideas ? (In reply to Kurt Jaeger from comment #6) > I tried to build it on 9.3a with your suggested changes, fails to build in > poudriere, see > > http://people.freebsd.org/~pi/logs/math__pdal-93a > > Any ideas ? This looks like yet another case of bug 193528. This should fix it: # Unhide std::to_string() to fix build with GCC (see ports/193528 for details) CXXFLAGS+= -D_GLIBCXX_USE_C99 Thanks, testbuild@work (In reply to Raphael Kubo da Costa from comment #7) I tried it, fails for 9.3a again. See http://people.freebsd.org/~pi/logs/math__pdal-93a-v2 But this time it looks like a type mismatch. Created attachment 168587 [details] Patch v2 OK, I've finally taken some time to investigate this and the attached patch builds on HEAD-amd64 and 9.3-i386. * Use USES=cmake:outsource instead of USES=cmake. Out-of-source builds are cleaner and showed that several build directories had been added to the package and the plist. * Implemented my suggestions (USES=compiler:c++11-lib and USES=pathfix). * Those many patches commenting out the portable_endian.hpp were just working around the fact that portable_endian.hpp was broken and needed to be fixed (the #defines translating FreeBSD functions into Linux ones were inverted). * The PointViewTest.cpp patch was also working around a problem in the embedded gtest, that was lacking a platform definition for FreeBSD. * The nanoflann.hpp patch only needs the cstdlib include, the rest is not necessary. Kurt and coder@tuxfamily.org, please take a look at this new patch and let me know if it's OK for you. testbuilds@work Testbuilds are all fine I'll go ahead and commit my version of the update patch. Kurt and I have both verified it works. A commit references this bug: Author: rakuco Date: Mon Mar 28 19:21:18 UTC 2016 New revision: 412068 URL: https://svnweb.freebsd.org/changeset/ports/412068 Log: Update to 1.1.0. Includes compatibility with the upcoming Boost 1.60. Original patch from the maintainer himself, and additional adjustments by me. Also thanks to pi@ for helping test-build the update. PR: 207059 Submitted by: coder@tuxfamily.org (maintainer, first version) Approved by: coder@tuxfamily.org (maintainer) Changes: head/math/pdal/Makefile head/math/pdal/distinfo head/math/pdal/files/patch-git_080e614 head/math/pdal/files/patch-git_3c7e997 head/math/pdal/files/patch-git_5a0b123 head/math/pdal/files/patch-git_c8a1f88 head/math/pdal/files/patch-src-Utils.cpp head/math/pdal/files/patch-src_PluginManager.cpp head/math/pdal/files/patch-vendor_gtest-1.7.0_include_gtest_internal_gtest-port.h head/math/pdal/pkg-plist Thanks everyone! |