Bug 207117
| Summary: | mail/ssmtp: Config file is parsed incorrectly if '#' character is part of an option value | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Sergey Manucharian <sm> | ||||||
| Component: | Individual Port(s) | Assignee: | Lars Engels <lme> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | aragon, lme, sm, vlad-fbsd | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | Flags: | linimon:
maintainer-feedback?
(aragon) |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=544018 | ||||||||
| Attachments: |
|
||||||||
First of all, this is maintainer timeout, so a committer please look at the issue. The upstream is dead. This was reported many years ago with no resolution: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=544018 Gentoo has some fixes as well: https://bugs.gentoo.org/show_bug.cgi?id=258018 I vote for this patch to be added to FreeBSD, regardless of upstream. However, there are reports about other chars being problematic in AuthPass as well: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=463196 Can this patch be reworked to include those too, while at it? Thanks, Vladimir! I'll rework my patch to include other problematic characters as well. Created attachment 175355 [details]
a patch to the existing FreeBSD patch
fixes parsing of ssmtp config file: characters "#' and "=" can be used in user passwords.
The Debian bug mentioned above is related to ssmtp-2.61: characters "=" and ":" are not parsed correctly in "AuthPass" field. FreeBSD has ssmtp-2.64 in ports. I checked it and found that there is no problem with ":", but confirm that "=" is not working in password. It is an obvious bug in the config file parser: it uses "=" among the "end of parameter" characters. The patched attached fixes that. Committed, thanks! Sorry that it took so long! A commit references this bug: Author: lme Date: Thu Nov 23 21:32:48 UTC 2017 New revision: 454801 URL: https://svnweb.freebsd.org/changeset/ports/454801 Log: mail/ssmtp: - Add a patch to allow passwords containing = and # characters - Bump PORTREVISION PR: 207117 Submitted by: Sergey Manucharian <sm@ara-ler.com> Approved by: maintainer timeout (21 months) MFH: 2017Q4 Changes: head/mail/ssmtp/Makefile head/mail/ssmtp/files/patch-ssmtp.c A commit references this bug: Author: lme Date: Fri Nov 24 08:04:35 UTC 2017 New revision: 454812 URL: https://svnweb.freebsd.org/changeset/ports/454812 Log: MFH: r454801 mail/ssmtp: - Add a patch to allow passwords containing = and # characters - Bump PORTREVISION PR: 207117 Submitted by: Sergey Manucharian <sm@ara-ler.com> Approved by: maintainer timeout (21 months) Approved by: ports-secteam (junovich) Changes: _U branches/2017Q4/ branches/2017Q4/mail/ssmtp/Makefile branches/2017Q4/mail/ssmtp/files/patch-ssmtp.c |
Created attachment 166879 [details] a patch to the existing patch for ssmtp.c file The bug appears when a '#' is used in values of variables in the config file. For example, using the following password: AuthPass=my#password will cause that everything beyond # to be ignored as a comment. The patch attached adds a check for '=' character: if it appears before '#' do not ignore '#' and the followed characters.