Bug 207136

Summary: multimedia/ffmpeg -- aid debugging and trouble-shooting
Product: Ports & Packages Reporter: Mikhail T. <freebsd-2024>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Only Me CC: freebsd-2024, riggs
Priority: --- Keywords: easy, patch-ready
Version: LatestFlags: riggs: maintainer-feedback+
riggs: merge-quarterly+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Use the upstream's configure better none

Description Mikhail T. 2016-02-12 20:26:11 UTC 
Created attachment 166907 [details]
Use the upstream's configure better

The upstream's configure no longer uses configure.err -- the errors are in the usual configure.log now. They would also strip everything themselves -- unless asked not to.

Other debug-enabling flags also exist, but may be troublesome in their own right (see https://trac.ffmpeg.org/ticket/5234), so I'm not suggesting them here, but the attached patch would help future troubleshooting and error-reporting for the port.
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2016-02-13 12:28:29 UTC 
The part regarding CONFIGURE_LOG is correct. Will fix this and request MFH for it.

The stripping part is already taken care of by an OPTION helper, though:

[riggs] /usr/ports/multimedia/ffmpeg > grep strip Makefile
DEBUG_CONFIGURE_ON=	--disable-stripping
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-02-13 12:32:27 UTC 
A commit references this bug:

Author: riggs
Date: Sat Feb 13 12:31:58 UTC 2016
New revision: 408791
URL: https://svnweb.freebsd.org/changeset/ports/408791

Log:
  Remove CONFIGURE_LOG

  ffmpeg now uses config.log instead of previously config.err.
  Setting CONFIGURE_LOG in port Makefile has become obsolete.
  No change in resulting package, no PORTREVISION bump.

  PR:		207136
  Submitted by:	mi@ALDAN.algebra.com
  Reviewed by:	riggs
  MFH:		2016Q1

Changes:
  head/multimedia/ffmpeg/Makefile
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-02-13 15:34:42 UTC 
A commit references this bug:

Author: riggs
Date: Sat Feb 13 15:34:26 UTC 2016
New revision: 408804
URL: https://svnweb.freebsd.org/changeset/ports/408804

Log:
  MFH: r408791

  Remove CONFIGURE_LOG

  ffmpeg now uses config.log instead of previously config.err.
  Setting CONFIGURE_LOG in port Makefile has become obsolete.
  No change in resulting package, no PORTREVISION bump.

  PR:		207136
  Submitted by:	mi@ALDAN.algebra.com
  Reviewed by:	riggs
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2016Q1/
  branches/2016Q1/multimedia/ffmpeg/Makefile
Comment 4 Mikhail T. 2016-02-13 17:48:28 UTC 
(In reply to Thomas Zander from comment #1)
> DEBUG_CONFIGURE_ON=	--disable-stripping

Ah, sorry, I didn't notice it. However, the WITH_DEBUG knob is a standard way of enabling debuggable builds. bsd.ports.mk, upon finding it defined, will massage CFLAGS and CXXFLAGS to remove any -O* and to add -g. It will also remove the -s option from the INSTALL_* macros (to avoid install(1) stripping the installed programs), etc.

You, probably, should revise the port's options-handling to properly treat this standard flag. Perhaps, in some combination with the DEBUG_CONFIGURE, that is specific to this port...