Bug 207229
| Summary: | security/pam_google_authenticator: update to 1.01.20160208 snapshot | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ralf van der Enden <tremere> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Raphael Kubo da Costa <rakuco> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Many People | CC: | crest, jnlin, pi, rakuco | ||||||||||
| Priority: | --- | Keywords: | patch-ready | ||||||||||
| Version: | Latest | Flags: | rakuco:
maintainer-feedback-
|
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 167053 [details]
Poudriere buildlog
Can you please clarify where the maintainer approved this patch? Or where he provided feedback (the meaning of "maintainer-feedback+" flag). I hadn't meant to set it to +, but to ? instead. Sorry about that. CC'ing the maintainer's new email address just in case that's why he hasn't responded to this bug. (In reply to Ralf van der Enden from comment #0) > Created attachment 167052 [details] > - update to 1.01.20160208 snapshot > > Update to 1.01.20160208 snapshot. Hi Ralf, A few suggestions of other things that can be improved in this update: - The port now uses autotools, so you can use GNU_CONFIGURE=yes instead of HAS_CONFIGURE=yes. - Similarly, since it uses autotools you don't need a custom do-install target (or the bsd.port.options.mk include either: you can just rely on `make install' to work (the plist changes though). Created attachment 167774 [details]
New patch
I've replaced my previous patch with a new one that now has all the suggestions made by Raphael
A commit references this bug: Author: rakuco Date: Sun Mar 6 20:00:33 UTC 2016 New revision: 410480 URL: https://svnweb.freebsd.org/changeset/ports/410480 Log: Update to the 1.01.20160208 snapshot. - Removed STEPSIZE option since it's now part of the code (which also makes the patches obsolete). - The upstream code is now hosted on GitHub, so use USE_GITHUB=yes. - The upstream code now has a proper buildsystem, which allows us to simplify the code quite significantly. PR: 207229 Submitted by: Ralf van der Enden <tremere@cainites.net> Approved by: maintainer timeout (20 days) Changes: head/security/pam_google_authenticator/Makefile head/security/pam_google_authenticator/distinfo head/security/pam_google_authenticator/files/ head/security/pam_google_authenticator/pkg-plist Thanks, that looks better! Upgrade changed path to .so, which caused failure: https://lists.freebsd.org/pipermail/freebsd-ports/2016-March/102384.html Raphael, can you add some note to UPDATING ? Created attachment 167858 [details]
Fix installation location of the .so file
This patch makes sure the .so is installed in the "old" location.
Bumped the PORTREVISION to make sure everyone gets it.
Sorry for missing this in my latest update.
testbuilds are fine. Sorry about the breakage :( I noticed the location would change, but thought it wouldn't be a problem (that only shows how much I know about PAM). Kurt, please feel free to commit it if you have time, otherwise I'll do that later today or tomorrow. Thanks everyone for acting so fast! A commit references this bug: Author: pi Date: Tue Mar 8 20:43:20 UTC 2016 New revision: 410660 URL: https://svnweb.freebsd.org/changeset/ports/410660 Log: security/pam_google_authenticator: fix .so location - move .so location back to where it was PR: 207229 Submitted by: Ralf van der Enden <tremere@cainites.net> Approved by: just-fix-it Changes: head/security/pam_google_authenticator/Makefile head/security/pam_google_authenticator/pkg-plist A commit references this bug: Author: pi Date: Tue Mar 8 20:45:15 UTC 2016 New revision: 410661 URL: https://svnweb.freebsd.org/changeset/ports/410661 Log: security/pam_google_authenticator: fix space/tab in Makefile PR: 207229 Changes: head/security/pam_google_authenticator/Makefile Committed, thanks to all. A damn UPDATING entry would have been nice. This way my sshd PAM configuration broke *twice* without notice. Sorry! |
Created attachment 167052 [details] - update to 1.01.20160208 snapshot Update to 1.01.20160208 snapshot. Removed STEPSIZE option since it's now part of the code (which also makes the patches obsolete). Changed from local MASTERDIR to GITHUB Fixed staging for lib/pam_google_authenticator.so Removed: D files D files/patch-Makefile D files/patch-pam_google_authenticator.c