Bug 207265
| Summary: | [PATCH] irc/ircd-ratbox pre-build target broken | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Marshall <john> | ||||
| Component: | Individual Port(s) | Assignee: | Bernard Spil <brnrd> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | brnrd, moggie | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(moggie) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://reviews.freebsd.org/D5479 | ||||||
| Attachments: |
|
||||||
|
Description
John Marshall
2016-02-17 00:37:37 UTC
Created attachment 167103 [details]
Extract bsd.port.options.mk from the middle of the pre-build target script
Guessing that moving the bsd.port.options.mk .include into the middle of the pre-build target script in r408952 was unintentional. This is what it does...
rwsrv04# cd irc/ircd-ratbox
rwsrv04# make clean
make: "/build/ports/irc/ircd-ratbox/Makefile" line 135: Unassociated shell command "@${ECHO_MSG} "Executing ircd-shortcut.pl for ircd-shortcuts generation.""
make: "/build/ports/irc/ircd-ratbox/Makefile" line 136: Unassociated shell command "${PERL} ${WRKSRC}/contrib/ircd-shortcut.pl"
make: Fatal errors encountered -- cannot continue
make: stopped in /build/ports/irc/ircd-ratbox
The attached patch relocates the .include, hopefully to its proper place.
Hi John, Thanks for the patch. The include must indeed happen before the target definitions. See review D5479 Hope to commit this soon (pending mentor review) |
