Bug 207273

Summary: astro/gpsd: update to 3.16
Product: Ports & Packages Reporter: John Hein <jcfyecrayz>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Some People CC: glebius
Priority: --- Flags: jcfyecrayz: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
[patch] update port to 3.16
none
[patch] [v2] add libgpsd.pc back to plist
none
[patch] [v3] update gpsd to 3.16 jcfyecrayz: maintainer-approval+

Description John Hein 2016-02-17 11:07:36 UTC 
Created attachment 167107 [details]
[patch] update port to 3.16

Attached patch updates this port from 3.14 to 3.16.

FYI, the patch removes three files/patch-* files.  It's not exactly clear from looking at diffs - the committer should 'svn rm' those, of course.

Note: it's still susceptible to linker errors in bug 178732 if today's version of the ncurses port is enabled (which is the default) and has not been patched per comment 9 there [1].

QA:
  - stage-qa: ok
  - portlint: ok (no new warnings)
  - poudriere testport: fails (9-stable/32) [caveat: [1] ncurses patch required or ncurses disabled]

testport fails because:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: libdata/pkgconfig/libgpsd.pc

This I removed from pkg-plist spefically because libgpsd is no longer installed.  See upstream submission:

http://lists.nongnu.org/archive/html/gpsd-dev/2016-02/msg00032.html

I could fix the patch to not remove libgpsd.pc from pkg-plist, or do something to prevent installation or remove it from the staging area.  'make stage install' works fine, however.  And it has the intended effect of not installing or packaging libgpsd.pc.  If that's not acceptable, the easy thing is to just put libgpsd.pc back in pkg-plist and live with the vestigial file.



from NEWS:
===============
3.16: 2016-01-08 (Eric S. Raymond <esr@snark.thyrsus.com>)
  Test rebuilds for mid-2015 leapsecond bump. Regression tests will
  run even if "python" in Python 3.  Build correctly on systems where
  -ltinfo is split from -lncurses. Avoid some rare overflow conditions
  in PPS code.  Fix bugs in JSON sat-view parsing due to the JSON
  parser stuffing ints into shorts.  Various small fixes to AIS
  interpretation.  Prevent a memory leak in long-running gpsmon
  instances.  Fix Savannah bug #45270: serial driver does not work
  properly on pipes.  Fix Savannah bug #44648: GPSD won't build if
  CCFLAGS contains options that are only compatible with the
  cros1s-compiler. Fix Savannah bug #45342: SConstruct generates wrong
  *.pc files.  Fix Savannah bug #46495: gpsd_poll may crash due to
  unitialized pointer (probably due to bugg FD_ISSET on hos
  system). Fix Savannah bug #46648: gpsd crashes and buffer overflow
  is reported when terminated.  Fix Savannah bug #46802: AIVDM to CSV
  is broken in some weird cases. Fix Savannah bug #46804: JSON
  satellite view parsing is somewhat broken.

3.15: 2015-06-03 (Eric S. Raymond <esr@snark.thyrsus.com>)
  Fix a rare crash bug related to devices becoming inaccessible while timed out.
  Accept NMEA 4.1 GSV sententences with the trailing signal-ID field.
  Fixed incorrect decode of south latitudes in AIS Type 17 messages.
  splint has been retired; this removes almost 2KLOC of annotations.
  chrpath is no longer a build dependency. Corrected Beidou/QZNSS display
  in the Python clients so the graphics don't look like SBAS.
==============
Comment 1 John Hein 2016-02-17 11:12:08 UTC 
Created attachment 167108 [details]
[patch] [v2] add libgpsd.pc back to plist

Attached is a new patch that adds libgpsd.pc back to the plist.

Now testport passes (still with the caveat of a patched ncurses or disabled NCURSES option).
Comment 2 John Hein 2016-02-17 11:16:34 UTC 
Added dependency on bug 178732.  It's not strictly required - you could disable NCURSES as well.  But since NCURSES is currently on by default, it's effectively required.
Comment 3 John Hein 2016-05-05 23:37:37 UTC 
Gleb,
Do I have to set 'maintainer-feedback+' to approve my own submission now that I am maintainer?
Comment 4 John Hein 2016-12-11 22:09:52 UTC 
Created attachment 177888 [details]
[patch] [v3] update gpsd to 3.16

Refresh patch against current version of ports files.

One addition: explicitly disable DBUS if DBUS option is off (avoids implicitly enabling of dbus support if dbus port happens to be installed).

Please commit.
Comment 5 John Hein 2016-12-11 22:13:10 UTC 
bug 178732 is no longer a blocker (ncurses was finally fixed to address the issue that affected gpsd when the ncurses port was installed in October - see bug 209526)
Comment 6 John Hein 2017-01-30 02:25:16 UTC 
Ready for a committer.  Resetting assignee.  I didn't see official docs whether that's the correct thing to do when ready for a committer.  Let me know if there's a better procedure.
Comment 7 John Hein 2017-03-27 23:26:11 UTC 
Can this get committed, please?
Comment 8 John Hein 2017-04-28 21:16:52 UTC 
Another month, another ping...  please commit.
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-05-02 16:27:12 UTC 
A commit references this bug:

Author: amdmi3
Date: Tue May  2 16:26:15 UTC 2017
New revision: 439960
URL: https://svnweb.freebsd.org/changeset/ports/439960

Log:
  - Update to 3.16

  PR:		207273
  Submitted by:	z7dr6ut7gs@snkmail.com (maintainer)

Changes:
  head/astro/gpsd/Makefile
  head/astro/gpsd/distinfo
  head/astro/gpsd/files/patch-SConstruct
  head/astro/gpsd/files/patch-compiler.h
  head/astro/gpsd/files/patch-libgps.pc.in
  head/astro/gpsd/files/patch-libgpsd.pc.in
  head/astro/gpsd/pkg-plist
Comment 10 Dmitry Marakasov freebsd_committer freebsd_triage 2017-05-02 18:13:20 UTC 
Sorry for the wait. This was delayed multiple times because plist problems were discovered and it required a lot of test builds.