Summary: | www/webkit2-gtk3 using armv6t2 ASM instructions on armv6 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Sean Bruno <sbruno> | ||||||
Component: | Individual Port(s) | Assignee: | freebsd-gnome (Nobody) <gnome> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | brd, dim, mikael, otacilio.neto, rm, trentnthompson | ||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(gnome) |
||||||
Version: | Latest | ||||||||
Hardware: | arm | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Sean Bruno
![]() ![]() Created attachment 168612 [details] poudriere build log. I got a error when compiling www/webkit2-gtk3 to ARM usig poudriere. Attached is the poudriere log. I don't got if this error is related with this Bug 207275 but Im sending the log because I think that can help in some form. Please try latest port version [1] from development repo and let us know if it makes any difference. Thanks. https://github.com/freebsd/freebsd-ports-gnome/tree/gnome-3.20/www/webkit2-gtk3 Created attachment 172758 [details] armv6 fix The problem was introduced with this commit: https://bugs.webkit.org/show_bug.cgi?id=131612#c17 A PR is opened upstream for more than a year now without a fix: https://bugs.webkit.org/show_bug.cgi?id=141288 I don't know how to fix the assembly but compiling webkit without JIT workaround the issue. I know it's lame but I can't do better. See attached patch Quote from #211216 "I know this is probably not what you wanted to hear, but I tried out the patch from #207275 and it would fail at patching the bmalloc_BPlatform.h stuff. I edited the diff to remove everything past the line: Index: files/patch-Source_bmalloc_bmalloc_BPlatform.h and the patch completed and the build worked." The bmalloc_BPlatform.h patch is needed if you use the development repo that Ruslan Makhmatkhanov posted at comment 2. I agree that it's not needed if you use the ports at r419069. Sorry about the confusion. No worries, thank you for the work! A commit references this bug: Author: brd Date: Tue Sep 13 15:34:28 UTC 2016 New revision: 422019 URL: https://svnweb.freebsd.org/changeset/ports/422019 Log: Fix build of www/webkit2-gtk3 on armv6 by matching the correct define and disabling the JIT compiler. PR: 207275 Submitted by: mikael.urankar@gmail.com Reported by: sbruno Reviewed by: bdrewery (implicit) Approved by: maintainer timeout Changes: head/www/webkit2-gtk3/Makefile head/www/webkit2-gtk3/files/patch-Source_WTF_wtf_Platform.h head/www/webkit2-gtk3/files/patch-Source_bmalloc_bmalloc_BPlatform.h Fixed in r422019. Thank you for all your work! A commit references this bug: Author: antoine Date: Wed Sep 14 05:43:13 UTC 2016 New revision: 422112 URL: https://svnweb.freebsd.org/changeset/ports/422112 Log: Revert r422019, patch fails to apply PR: 207275 Reported by: pkg-fallout Changes: head/www/webkit2-gtk3/Makefile head/www/webkit2-gtk3/files/patch-Source_WTF_wtf_Platform.h head/www/webkit2-gtk3/files/patch-Source_bmalloc_bmalloc_BPlatform.h A commit references this bug: Author: brd Date: Sun Sep 25 12:19:16 UTC 2016 New revision: 422748 URL: https://svnweb.freebsd.org/changeset/ports/422748 Log: Try #2 for fixing build of www/webkit2-gtk3 on armv6 by matching the correct define and disabling the JIT compiler. PR: 207275 Submitted by: mikael.urankar@gmail.com Reported by: sbruno Reviewed by: bdrewery (implicit) Approved by: maintainer timeout Changes: head/www/webkit2-gtk3/Makefile head/www/webkit2-gtk3/files/patch-Source_WTF_wtf_Platform.h |