Bug 207295

Summary: databases/pecl-memcache compilation failure with lang/php70
Product: Ports & Packages Reporter: Jack <xxjack12xx>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me CC: gasol.wu, miwi, olivierw1+bugzilla-freebsd, ports-bugs, sunpoet, tz
Priority: --- Keywords: needs-qa
Version: LatestFlags: koobs: maintainer-feedback? (sunpoet)
koobs: merge-quarterly?
Hardware: Any   
OS: Any   
Attachments:
Description Flags
make failure none

Description Jack 2016-02-18 03:15:28 UTC
Created attachment 167135 [details]
make failure

pecl-memcache does not compile with php 7 installed

/usr/ports/databases/pecl-memcache/work/memcache-3.0.8/memcache_pool.c:38:10: fatal error: 'ext/standard/php_smart_str.h' file not found
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2016-02-18 03:23:39 UTC
i take this.
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2016-07-25 19:12:48 UTC
miwi@ resigned.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-09-08 15:11:13 UTC
Assign to maintainer so this issue doesn't end up orphaned. 

CC php70 maintainer (tz) in case they can help
Comment 4 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-09-08 16:30:48 UTC
Its a known bug in the software itself. There is a Git-Repo with propose to fix it:
https://github.com/websupport-sk/pecl-memcache/tree/php7

But since the software itself got its last release in 2013 we really need somebody who take over the upstream-repo and fixes it there. Or try to find the diff between upstream and the git-repo and add the patches. :D
Comment 5 Gasol Wu 2016-09-09 04:20:21 UTC
(In reply to Torsten Zuehlsdorff from comment #4)

I will give it a try.
Comment 6 OlivierW 2016-09-15 15:30:44 UTC
Hello,

There's already a FreeBSD ports in github: https://github.com/O2Graphics/php70-pecl-memcache based on the repo indicated by tz@.
It works very well.
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2016-12-17 13:15:15 UTC
databases/php70-memcache was added to ports tree. You could use it for PHP 7. Thanks!
Comment 8 OlivierW 2016-12-31 21:11:49 UTC
Hello and thanks sunpoet for your port! I'm now using it instead of the one I posted from github.

Not sure if I should open a PR: your port mention version 3.0.8_1 while I think it should probably be 3.0.9_1: https://github.com/websupport-sk/pecl-memcache/blob/NON_BLOCKING_IO_php7/php7/php_memcache.h#L69