Bug 207541
| Summary: | mail/mimedefang doesn't package when DOCS and EXAMPLES are unset | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Stewart Morgan <stewart+FreeBSD-BugZilla> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | m.tsatsenko | ||||
| Priority: | --- | Flags: | m.tsatsenko:
maintainer-feedback-
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Hello, Thanks for reporting this. But as far I can see those @dir lines are not required at all and can be removed safely. Hello, From my understanding[*], any directory that is created in the port Makefile (which both DOCSDIR and EXAMPLESDIR are) should be added to the pkg-plist file for removal upon package deinstallation...? [*]:https://www.freebsd.org/doc/en/books/porters-handbook/plist-cleaning.html Hello. Above applies to empty directories only. In our case the directories are not empty and handled by pkg automatically. Hello, Ah yes, re-reading the Makefile that does appear to be the case! :) Please remove them as you intended! Thanks. A commit references this bug: Author: amdmi3 Date: Mon Mar 28 02:03:47 UTC 2016 New revision: 412027 URL: https://svnweb.freebsd.org/changeset/ports/412027 Log: - Fix plist issue which leads to packaging failure with disabled DOCS or EXAMPLES PR: 207541 Submitted by: stewart.morgan@gmail.com Approved by: m.tsatsenko@gmail.com (maintainer) Changes: head/mail/mimedefang/pkg-plist |
Created attachment 167477 [details] Patch to fix pkg-plist Hello, Building the port with "OPTIONS_UNSET+= DOCS EXAMPLES" fails at the package stage because the %%PORTDOCS%% and %%PORTEXAMPLES%% macros are the wrong side of the @dir directive. The attached patch puts them in the right place and the port succeeds for me. Thanks, Stewart.