Bug 207688
| Summary: | graphics/bmeps: Update to 4.2.2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | takefu | ||||||
| Component: | Individual Port(s) | Assignee: | Raphael Kubo da Costa <rakuco> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | rakuco, takefu | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Hi, Have you tried building this update on Poudriere? It doesn't start because you reverted the USES=jpeg change. In addition to that: - Setting CONFIGURE_ARGS does not seem to be necessary. - The sed call commenting out sz->lsz are wrong. Instead of removing the assignments, you should fix them (use st->lsz instead). - The HAVE_DB_H changes in pre-patch does not seem necessary. - By the way, for this kind of changes, we normally use the post-patch target. - It'd be good if you added a comment explaining why you're changing CONFIGURE_ENV. It took me a while to figure out why you don't need db.h, for example. Created attachment 167787 [details]
Thanks for the advice. Based on rewrite.
I'll land a slightly different version: - Since the port was not created by you, I'm restoring the "Created by" line, as the author has not indicated it was fine to remove it. - I'm removing the commented out line setting PORTREVISION. There's no need to keep a dead line there. - I'm adding a comment explaining why CONFIGURE_ENV is set like I suggested you did. A commit references this bug: Author: rakuco Date: Wed Mar 9 17:15:19 UTC 2016 New revision: 410714 URL: https://svnweb.freebsd.org/changeset/ports/410714 Log: Update to 4.2.2. * It is no longer necessary to set CONFIGURE_ARGS. * Explain why we set CONFIGURE_ENV. PR: 207688 Submitted by: takefu@airport.fm Changes: head/graphics/bmeps/Makefile head/graphics/bmeps/distinfo |
Created attachment 167700 [details] Update to 4.2.2