Bug 207782
| Summary: | New port: audio/dsbmixer: Tabbed GTK+ mixer | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Marcel Kaiser <mk> | ||||||||||||||||||
| Component: | Individual Port(s) | Assignee: | Raphael Kubo da Costa <rakuco> | ||||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||||
| Severity: | Affects Only Me | CC: | rakuco | ||||||||||||||||||
| Priority: | --- | Keywords: | feature, patch | ||||||||||||||||||
| Version: | Latest | ||||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||||
| OS: | Any | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Marcel Kaiser
2016-03-07 18:02:41 UTC
Created attachment 167818 [details]
Poudriere build log (10.2R, i386)
Created attachment 167821 [details]
Poudriere build log (10.1R, i386)
Created attachment 167833 [details]
Poudriere build log (9.3R, i386)
Hi,
A few suggestions you can follow to simplify the Makefile:
- There's an NLS description in Mk/bsd.options.desc.mk that can be used so you don't need to set NLS_DESC.
- Instead of including bsd.port.options.mk and checking for the options, you can use the syntax helpers:
NLS_MAKE_ARGS_OFF= -DWITHOUT_GETTEXT
# you can unconditionally set NLS_LANGS
DEVD_MAKE_ARGS_OFF= -DWITHOUT_DEVD
- dsbmixer's Makefile already has an install target, so you shouldn't need to define do-install yourself. Since you are also dsbmixer's upstream author, I suggest you just improve its Makefile to support the DESTDIR variable: this would allow `make stage' to work without any changes and everything would work out of the box.
- Speaking of upstream, something you should consider is to ship a separate COPYING or LICENSE file with the license the code is licensed under.
Created attachment 168090 [details]
Shar archived port, revised
Created attachment 168091 [details]
Poudriere build log (10.2R, i386)
Created attachment 168092 [details]
Poudriere build log (10.1R, i386)
Created attachment 168094 [details]
Poudriere build log (9.3R, i386)
A commit references this bug: Author: rakuco Date: Sun Mar 13 14:41:45 UTC 2016 New revision: 410972 URL: https://svnweb.freebsd.org/changeset/ports/410972 Log: New port: audio/dsbmixer. DSBMixer is a tabbed GTK+ mixer for FreeBSD. For each installed mixer device as well as for USB sound devices plugged in at runtime, DSBMixer opens a tab. Furthermore, it allows you to configure several aspects of your sound card(s), such as selecting recording sources, choosing your default audio device, and amplification. WWW: http://freeshell.de/~mk/projects/dsbmixer.html PR: 207782 Submitted by: Marcel Kaiser <mk@nic-nac-project.org> Changes: head/audio/Makefile head/audio/dsbmixer/ head/audio/dsbmixer/Makefile head/audio/dsbmixer/distinfo head/audio/dsbmixer/pkg-descr head/audio/dsbmixer/pkg-plist Committed, thank you! Excellent! Thank you. |
