Bug 207879

Summary: sysutils/freefilesync: unbreak on 10.x
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Only Me CC: kevlo, portmgr
Priority: --- Keywords: needs-qa, patch
Version: LatestFlags: jbeich: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v0
jbeich: maintainer-approval? (kevlo)
simple version (depends on review D5607)
none
ugly version none

Description Jan Beich freebsd_committer freebsd_triage 2016-03-10 13:31:07 UTC 
Created attachment 167963 [details]
v0

clang34 (in base) on 10.x systems doesn't support C++14.

    error: invalid value 'c++14' in '-std=c++14'

http://beefy5.nyi.freebsd.org/data/101i386-default/410738/logs/errors/freefilesync-7.9.log

futimens/utimensat have only been MFC'd to 10.3 in base r293474.

  ../../zen/file_access.cpp:893:15: error: no member named 'futimens' in the global namespace
          if (::futimens(fdFile, newTimes) != 0)
              ~~^
  ../../zen/file_access.cpp:898:15: error: no member named 'utimensat' in the global namespace
          if (::utimensat(AT_FDCWD, filePath.c_str(), newTimes, AT_SYMLINK_NOFOLLOW) != 0)
              ~~^
  2 errors generated.
Comment 1 Kevin Lo freebsd_committer freebsd_triage 2016-03-11 01:52:42 UTC 
Thanks for the quick fix.  Could you commit your patch?  Thank you.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2016-03-11 07:41:31 UTC 
I couldn't land as is because Subversion properties are PITA. v0 combines both Unix and DOS line endings which upsets |svn add| but then our style[1] forbids svn:eol-style != native. See review D5607 for proper fix.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-03-11 07:42:01 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Mar 11 07:41:19 UTC 2016
New revision: 410810
URL: https://svnweb.freebsd.org/changeset/ports/410810

Log:
  mainsysutils/freefilesync: unbreak build on 10.x

  error: invalid value 'c++14' in '-std=c++14'

  ../../zen/file_access.cpp:893:15: error: no member named 'futimens' in the global namespace
          if (::futimens(fdFile, newTimes) != 0)
              ~~^
  ../../zen/file_access.cpp:898:15: error: no member named 'utimensat' in the global namespace
          if (::utimensat(AT_FDCWD, filePath.c_str(), newTimes, AT_SYMLINK_NOFOLLOW) != 0)
              ~~^
  2 errors generated.

  PR:		207879
  Reported by:	pkg-fallout
  Approved by:	kevlo (maintainer, previous version)

Changes:
  head/sysutils/freefilesync/Makefile
  head/sysutils/freefilesync/files/patch-zen_file__access.cpp
Comment 4 Jan Beich freebsd_committer freebsd_triage 2016-03-11 07:57:31 UTC 
Of course, git-svn screwed up ^M (carriage-return). Mk/Uses/dos2unix.mk
removed svn:eol-style to handle it but regular ports are forbidden to
mess with properties (cf. Committer's Guide). Backing out...
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-03-11 08:04:04 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Mar 11 08:03:50 UTC 2016
New revision: 410811
URL: https://svnweb.freebsd.org/changeset/ports/410811

Log:
  sysutils/freefilesync: back out r207879 to fix INDEX bustage

  PR:		207879

Changes:
  head/sysutils/freefilesync/Makefile
  head/sysutils/freefilesync/files/patch-zen_file__access.cpp
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-03-11 08:10:06 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Mar 11 08:09:25 UTC 2016
New revision: 410813
URL: https://svnweb.freebsd.org/changeset/ports/410813

Log:
  sysutils/freefilesync: unbreak build on 10.x (partially r410811)

  error: invalid value 'c++14' in '-std=c++14'

  PR:		207879
  Reported by:	pkg-fallout
  Approved by:	kevlo (maintainer)

Changes:
  head/sysutils/freefilesync/Makefile
Comment 7 Jan Beich freebsd_committer freebsd_triage 2016-03-11 08:45:17 UTC 
Created attachment 167992 [details]
simple version (depends on review D5607)
Comment 8 Jan Beich freebsd_committer freebsd_triage 2016-03-11 08:46:09 UTC 
Created attachment 167993 [details]
ugly version
Comment 9 Jan Beich freebsd_committer freebsd_triage 2016-03-11 08:49:32 UTC 
Can portmgr advise a better fix or, at least, vote on the version it prefers?
Comment 10 Mathieu Arnold freebsd_committer freebsd_triage 2016-03-11 10:28:43 UTC 
commit D5607, and the simple version, it feels better.
Comment 11 commit-hook freebsd_committer freebsd_triage 2016-03-11 10:43:18 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Mar 11 10:42:55 UTC 2016
New revision: 410820
URL: https://svnweb.freebsd.org/changeset/ports/410820

Log:
  sysutils/freefilesync: unbreak build on 10.x (partially r410810)

  ../../zen/file_access.cpp:893:15: error: no member named 'futimens' in the global namespace
          if (::futimens(fdFile, newTimes) != 0)
              ~~^
  ../../zen/file_access.cpp:898:15: error: no member named 'utimensat' in the global namespace
          if (::utimensat(AT_FDCWD, filePath.c_str(), newTimes, AT_SYMLINK_NOFOLLOW) != 0)
              ~~^
  2 errors generated.

  PR:		207879
  Reported by:	pkg-fallout
  Approved by:	kevlo (maintainer, previous version)
  Reviewed by:	portmgr (mat)

Changes:
  head/sysutils/freefilesync/Makefile
  head/sysutils/freefilesync/files/patch-zen_file__access.cpp
Comment 12 Jan Beich freebsd_committer freebsd_triage 2016-03-11 10:49:52 UTC 
Thanks for quick response.
Comment 13 commit-hook freebsd_committer freebsd_triage 2016-03-11 11:27:22 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Mar 11 11:26:52 UTC 2016
New revision: 410824
URL: https://svnweb.freebsd.org/changeset/ports/410824

Log:
  sysutils/freefilesync: fixup runtime for DragonFly

  No PORTREVISION bump as DragonFly build is still broken.

  PR:		207879

Changes:
  head/sysutils/freefilesync/files/patch-zen_file__access.cpp