Bug 207946

Summary:	games/tbe: pkg-plist missing main executable and icons
Product:	Ports & Packages	Reporter:	John Marino <marino>
Component:	Individual Port(s)	Assignee:	Johan van Selst <johans>
Status:	Closed FIXED
Severity:	Affects Only Me	Flags:	bugzilla: maintainer-feedback? (johans)
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any

Description John Marino freebsd_committer

2016-03-13 10:21:43 UTC

the games/tbe port has had it's pkg-plist removed and replaced with the PORTS_DATA=* definition (also PORTS_DOCS=*, but this one is ok)

It's a common belief that PORT_DATA= should be removed and never used.  It's definitely abused here.
Using both synth and poudriere to test the port, it fails miserably:

===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%QT_BINDIR%%/tbe
Error: Orphaned: share/applications/tbe.desktop
Error: Orphaned: share/icons/hicolor/128x128/apps/tbe.png
Error: Orphaned: share/icons/hicolor/16x16/apps/tbe.png
Error: Orphaned: share/icons/hicolor/32x32/apps/tbe.png
Error: Orphaned: share/icons/hicolor/48x48/apps/tbe.png
Error: Orphaned: share/icons/hicolor/64x64/apps/tbe.png
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1


In my opinon, the proper fix is to remove PORT_DATA and return the pkg-plist to this port, and then test the new pkg-plist with "synth test" or "poudriere testport".  Apparently this has been broken a very long time.

Comment 1 John Marino freebsd_committer

2016-03-23 11:01:44 UTC

FYI, I'm planning on fixing tbe after this PR times out 4 days (if there's no indication that Johan is working on it)

Comment 2 commit-hook freebsd_committer

2016-03-27 22:46:22 UTC

A commit references this bug:

Author: marino
Date: Sun Mar 27 22:45:39 UTC 2016
New revision: 412019
URL: https://svnweb.freebsd.org/changeset/ports/412019

Log:
  games/tbe: Fix plist (main executable wasn't listed)

  At some port, this port was converted from having a plist to using
  PORTDATA as an automatic generator.  Unfortunately, this excluded the
  main executable (bin/tbe) from being packaged as well as several icons.
  Drop PORTDATA and bring back the full pkg-plist (it's < 300 lines).
  While here, pet portlint.

  PR:		207946
  Approved by:	maintainer timeout

Changes:
  head/games/tbe/Makefile
  head/games/tbe/pkg-plist