Summary: | make check doesn't use newly generated Kyuafile in /usr/obj | ||
---|---|---|---|
Product: | Base System | Reporter: | John Baldwin <jhb> |
Component: | tests | Assignee: | Enji Cooper <ngie> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | CC: | ngie |
Priority: | --- | ||
Version: | CURRENT | ||
Hardware: | Any | ||
OS: | Any |
Description
John Baldwin
2016-03-19 00:19:26 UTC
(In reply to John Baldwin from comment #0) Agreed. The default behavior was likely backwards from a usability perspective :/.. As helpful context for later... I discovered a simple case where this wouldn't work: if there were `FILES` that needed to be installed first, e.g. usr.sbin/nmtree/tests/, then `make check` would fail if there were files that needed to be installed first. brooks/jhb talked about this briefly with me, and there are some concerns that will potentially need to be handled in general using ${MAKEOBJDIRPREFIX}/... in ${LD_LIBRARY_PATH}, etc -- in particular we considered implementing "make buildenv" for tests, and I floated the idea of having a tool in tools/... for running make install DESTDIR=$(mktemp -d), then running the test binaries within that limited environment. Either way, it was recommended that the information for the "make check" target be more visible to end-users, via build(7), the FreeBSD Test Suite wiki page, etc. I'm going to mull over this a bit more and propose a solution after starting a discussion on -testing@. Does as of r322511. |