Bug 208146

Summary: net/ns3: simplify (56 lines shorter)
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Only Me CC: koue
Priority: --- Keywords: patch
Version: LatestFlags: koue: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v0 jbeich: maintainer-approval? (koue)

Description Jan Beich freebsd_committer freebsd_triage 2016-03-19 21:02:53 UTC
Created attachment 168402 [details]
v0

The port is written in suboptimal style which leads to a code/diff bloat. Let's prune the excess without altering default behavior.

- Convert to USES=waf (respects MAKE_JOBS_NUMBER)
- Convert to option helpers
- Define WRKSRC_SUBDIR after adjusting patches
- Drop/rename common option and their descriptions
- pkg-plist: rename WITH_DEBUG to DEBUG_SUFX to avoid confusion
- pkg-plist: define VERSION to avoid churn on updates
- post-install: compress multiple sh(1) loops via find(1) expressions

Build tested on 9.3R i386 with default and inverted options. Beware of typos still stands as some may not break it.
Comment 1 Nikola Kolev 2016-03-21 08:24:08 UTC
Approved.
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-03-21 11:18:20 UTC
A commit references this bug:

Author: jbeich
Date: Mon Mar 21 11:17:40 UTC 2016
New revision: 411552
URL: https://svnweb.freebsd.org/changeset/ports/411552

Log:
  net/ns3: simplify

  - Convert to USES=waf (respects MAKE_JOBS_NUMBER)
  - Convert to option helpers
  - Define WRKSRC_SUBDIR after adjusting patches
  - Drop/rename common option and their descriptions
  - pkg-plist: rename WITH_DEBUG to DEBUG_SUFX to avoid confusion
  - pkg-plist: define VERSION to avoid churn on updates
  - post-install: compress multiple sh(1) loops via find(1) expressions

  PR:		208146
  Approved by:	Nikola Kolev (maintainer)

Changes:
  head/net/ns3/Makefile
  head/net/ns3/files/patch-ns-3.24.1_src_wscript
  head/net/ns3/files/patch-ns-3.24.1_waf-tools_cflags.py
  head/net/ns3/files/patch-src_wscript
  head/net/ns3/files/patch-waf-tools_cflags.py
  head/net/ns3/pkg-plist
Comment 3 Jan Beich freebsd_committer freebsd_triage 2016-03-21 11:19:58 UTC
Thanks. Committed.