Bug 208162

Summary: [patch] emulators/wine-staging: add missing dependency on graphics/s2tc
Product: Ports & Packages Reporter: David Naylor <dbn>
Component: Individual Port(s)Assignee: David Naylor <dbn>
Status: Closed FIXED    
Severity: Affects Some People CC: dbn, gerald, mickael.maillot
Priority: --- Keywords: patch
Version: LatestFlags: gerald: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Makefile patch for STAGING_LIB_DEPENDS none

Description David Naylor freebsd_committer freebsd_triage 2016-03-20 19:42:36 UTC 
Created attachment 168434 [details]
Makefile patch for STAGING_LIB_DEPENDS

The attached patch adds a missing dependency on s2tc, this is required for the wined3d-DXTn patchset (https://github.com/wine-compholio/wine-staging/tree/master/patches/wined3d-DXTn).
Comment 1 mickael.maillot 2016-03-20 19:47:52 UTC 
+1
i confirm: with libtxc_dxtn.so wine with staging correctly use DXTn, tested with World of Warcraft for month now.
Comment 2 Gerald Pfeifer freebsd_committer freebsd_triage 2016-03-22 00:37:48 UTC 
Approved.

No PORTREVISION bump is necessary for wine-devel, since this does not
change the package for the default build.

I recommend you do bump PORTREVISION for wine-staging as part of the
same commit, since there things will change.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-03-22 06:26:05 UTC 
A commit references this bug:

Author: dbn
Date: Tue Mar 22 06:25:43 UTC 2016
New revision: 411637
URL: https://svnweb.freebsd.org/changeset/ports/411637

Log:
  emulators/wine-staging: add missing dependency.

  Add a missing dependency on libtxc_dxtn.so (provided by graphics/s2tc).

  PORTREVISION is not bumped (despite policy) for the following reasons:
   - Bumping PORTREVISION just for the slave port wine-staging is likely to
     result in human error later on (i.e. it will cause issues if wine-devel
     needs a bump, or an update).
   - Bumping both wine-devel and wine-staging is overkill.
   - The port is newly updated likely to catch most builds with this update
   - The port is updated every two weeks, so everyone gets the improvement
     quickly enough.
   - This change will be in the i386-wine-staging update.

  PR:		208162
  Reported by:	Mickael Maillot <mickael.maillot@gmail.com>
  Approved by:	gerald@

Changes:
  head/emulators/wine-devel/Makefile
Comment 4 David Naylor freebsd_committer freebsd_triage 2016-03-22 06:26:20 UTC 
Committed, thanks.