Bug 208255

Summary: Stop using sbrk(2) in devel/binutils
Product: Ports & Packages Reporter: Andrew Turner <Andrew>
Component: Individual Port(s)Assignee: Andrew Turner <Andrew>
Status: Closed FIXED    
Severity: Affects Only Me CC: Andrew, portmgr
Priority: --- Flags: bugzilla: maintainer-feedback? (bapt)
Andrew: exp-run?
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 207867    
Attachments:
Description Flags
Patch to stop using sbrk in devel/binutils none

Description Andrew Turner freebsd_committer freebsd_triage 2016-03-24 09:27:35 UTC 
Created attachment 168557 [details]
Patch to stop using sbrk in devel/binutils

We are planning on removing sbrk from arm64. Before we can do this we need to stop calling it from binutils so ld doesn't break.

The attached patch forces configure to assume it doesn't exist.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2016-03-25 15:33:28 UTC 
Hi,

What kind of failure do you expect?
Comment 2 Andrew Turner freebsd_committer freebsd_triage 2016-03-25 16:47:18 UTC 
I don't expect any failures, but Baptiste asked for an exp run when I talked to him about it at AsiaBSDCon.
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2016-03-26 19:54:17 UTC 
Exp-run didn't show any new failure (i386 and amd64).
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-03-29 14:10:42 UTC 
A commit references this bug:

Author: andrew
Date: Tue Mar 29 14:09:48 UTC 2016
New revision: 412112
URL: https://svnweb.freebsd.org/changeset/ports/412112

Log:
  Stop calling sbrk from binutils. This will help remive the need for this
  function on arm64.

  PR:		208255
  Approved by:	bapt
  Sponsored by:	ABT Systems Ltd

Changes:
  head/devel/binutils/Makefile