Bug 208265

Summary: net-p2p/gtk-gnutella: Fix build of gtk-gnutella 1.1.9 on FreeBSD 9
Product: Ports & Packages Reporter: Ben Woods <woodsb02>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/gtk-gnutella/gtk-gnutella/commit/e6f3adc8436a82ded5e8db3656eb5b6b3e64ddf4
Attachments:
Description Flags
Patch to fix gtk-gnutella 1.1.9 build errors on FreeBSD 9
woodsb02: maintainer-approval+
QA: Successful poudriere testport logs for net-p2p/gtk-gnutella 1.1.9 on FreeBSD 9.3 amd64 none

Description Ben Woods freebsd_committer freebsd_triage 2016-03-24 19:15:17 UTC 
Created attachment 168577 [details]
Patch to fix gtk-gnutella 1.1.9 build errors on FreeBSD 9

* Apply upstream patch to prevent pragmas being used for disabling warnings locally before gcc 4.8 [1]. This was introduced when a change was made in gtk-gnutella 1.1.9 to add pragmas to silence spurious warnings with the clang 3.4.1 compiler [2].


Build error on FreeBSD 9:
...
cc -c -I../.. -I.. -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -pthread  -DCURDIR=src/lib -O2 -pipe -isystem /usr/local/include -fstack-protector -fno-strict-aliasing -pthread -momit-leaf-frame-pointer -W -Wall -Wformat=2 -Wshadow -isystem /usr/local/include glog.c
glog.c: In function 'gl_logv':
glog.c:66: error: #pragma GCC diagnostic not allowed inside functions
glog.c:66: error: #pragma GCC diagnostic not allowed inside functions
glog.c:73: error: #pragma GCC diagnostic not allowed inside functions
*** [glog.o] Error code 1



 [1] https://github.com/gtk-gnutella/gtk-gnutella/commit/e6f3adc8436a82ded5e8db3656eb5b6b3e64ddf4
 [2] https://github.com/gtk-gnutella/gtk-gnutella/commit/3d47182ee7442373ecbc8785a696c631855d54f1
Comment 1 Ben Woods freebsd_committer freebsd_triage 2016-03-24 19:16:56 UTC 
Created attachment 168578 [details]
QA: Successful poudriere testport logs for net-p2p/gtk-gnutella 1.1.9 on FreeBSD 9.3 amd64
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-03-25 14:19:06 UTC 
A commit references this bug:

Author: amdmi3
Date: Fri Mar 25 14:18:16 UTC 2016
New revision: 411844
URL: https://svnweb.freebsd.org/changeset/ports/411844

Log:
  - Fix build on 9.x

  PR:		208265
  Submitted by:	woodsb02@gmail.com (maintainer)

Changes:
  head/net-p2p/gtk-gnutella/files/
  head/net-p2p/gtk-gnutella/files/patch-src_gcc.h