Bug 208302
| Summary: | editors/codelite: fix clang 3.7, add clang 3.8, fix brief comment support | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ivan Rozhuk <rozhuk.im> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Mathieu Arnold <mat> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Many People | CC: | mmokhi, rozhuk.im | ||||||||||||||
| Priority: | --- | Keywords: | easy, patch, patch-ready | ||||||||||||||
| Version: | Latest | ||||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 170851 [details]
patch fixes issue as well as fixing some QA problems
QA: done
poudriere Okay
portlint Okay
I think it's ready to committed in. DeAssiging from myself so that a committer comes and takes this :) All the patch could be folded into one command patching two files. (In reply to Mathieu Arnold from comment #3) You're talking about OPTIONS_RADIO_CLANG3[4 5 6] ? You mean it'd better not to use radio options, but to patch files in all cases ? Ah, no, I mean you're doing:
post-patch-CLANG35-on:
@${REINPLACE_CMD} -e \
's|/usr/lib/llvm-.*/|${LOCALBASE}/llvm35/|' \
${WRKSRC}/cmake/Modules/FindLibClang.cmake
+ @${REINPLACE_CMD} -e \
+ 's|/usr/lib/llvm-.*/|${LOCALBASE}/llvm35/|' \
+ ${WRKSRC}/cmake/Modules/FindLibLLDB.cmake
You could do:
post-patch-CLANG35-on:
@${REINPLACE_CMD} -e \
's|/usr/lib/llvm-.*/|${LOCALBASE}/llvm35/|' \
- ${WRKSRC}/cmake/Modules/FindLibClang.cmake
+ ${WRKSRC}/cmake/Modules/FindLibClang.cmake \
+ ${WRKSRC}/cmake/Modules/FindLibLLDB.cmake
Only one SED for two files.
Created attachment 171464 [details] Previous patch + liniting fixes + Mathieu's point applied (In reply to Mathieu Arnold from comment #5) Thanks Mathieu, Done ;) Created attachment 171638 [details]
Previous patch + liniting fixes + Mathieu's point applied WITHOUT Whitespace edits
To clarify exactly what is this patch doing (only one clear job per patch), I deleted white-space correcting parts from previous patch.
Created attachment 171641 [details]
Previous patch + liniting fixes + Mathieu's point applied WITHOUT Whitespace edits
Created attachment 171649 [details]
Previous patch + liniting fixes + Mathieu's point applied WITHOUT Whitespace edits
Correcting a typo (dup-string in cmake args)
A commit references this bug: Author: mat Date: Tue Jun 21 15:43:00 UTC 2016 New revision: 417275 URL: https://svnweb.freebsd.org/changeset/ports/417275 Log: fix clang 3.7, add clang 3.8, fix brief comment support [1] While there, refactor the CLANGXX options. PR: 208302 [1] Submitted by: maintainer, rozhuk im gmail com Sponsored by: Absolight Changes: head/editors/codelite/Makefile Committed with some refactoring. |
Created attachment 168644 [details] Makefile patch fix clang 3.7 code completion add clang 3.8 fix brief comment support