Bug 208305
| Summary: | [patch] geli(8): Negative iterations values dumped incorrectly | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Fabian Keil <fk> | ||||
| Component: | bin | Assignee: | freebsd-bugs (Nobody) <bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | geom, mav | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | CURRENT | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196834 | ||||||
| Attachments: |
|
||||||
As it turns out the issue was previously reported by Julian Hsiao as a side note of bug #196834. A commit references this bug: Author: mav Date: Fri Apr 21 07:43:44 UTC 2017 New revision: 317247 URL: https://svnweb.freebsd.org/changeset/base/317247 Log: Dump md_iterations as signed, which it really is. PR: 208305 PR: 196834 MFC after: 2 weeks Changes: head/sys/geom/eli/g_eli.h A commit references this bug: Author: mav Date: Sat May 6 00:51:26 UTC 2017 New revision: 317859 URL: https://svnweb.freebsd.org/changeset/base/317859 Log: MFC r317247: Dump md_iterations as signed, which it really is. PR: 208305 PR: 196834 Changes: _U stable/11/ stable/11/sys/geom/eli/g_eli.h |
Created attachment 168648 [details] geli(8): Dump negative iterations values properly The attached patch lets "geli dump" display negative iterations values properly. An iterations value of -1 signals that no passphrase is being used. Previously it was dumped incorrectly due to being cast to unsigned first: [fk@elektrobier ~]$ geli dump /dev/ada3p3 Metadata on /dev/ada3p3: magic: GEOM::ELI version: 7 flags: 0x2 ealgo: AES-XTS keylen: 256 provsize: 8589934592 sectorsize: 4096 keys: 0x01 iterations: 4294967295 Salt: [...] Master Key: [...] MD5 hash: 44e17ea9c25f27dff32179bc4f82f659 Obtained from: ElectroBSD