Summary: | multimedia/handbrake: Update to 0.10.5 | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Ben Woods <woodsb02> |
Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | CC: | riggs |
Priority: | --- | Keywords: | needs-qa, patch |
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any | ||
URL: | https://handbrake.fr/news.php?article=36 | ||
Attachments: |
Description
Ben Woods
2016-03-27 17:10:47 UTC
Created attachment 168701 [details]
QA: Successful poudriere testport logs for multimedia/handbrake 0.10.5 with patch on FreeBSD 11-current amd64 (gzipped)
Created attachment 168702 [details]
QA: Successful poudriere testport logs for multimedia/handbrake 0.10.5 with patch on FreeBSD 9.3 i386 (gzipped)
Created attachment 168729 [details]
Revised patch for X11 OPTION
Ben, your first patch does not build successfully without the X11 OPTION. This adds an ugly hack to make it compile.
In any case, I would like to turn fdk-aac into a non-default OPTION. For people building the port themselves and accepting license consequences, we should not just take away the best aac codec we currently have.
Pushed a new patch to phabricator for review: https://reviews.freebsd.org/D6077 Could you test it? Created attachment 169604 [details] Revised patch including FDK_AAC OPTION Patch is also available on https://reviews.freebsd.org/D6077 for review A commit references this bug: Author: riggs Date: Sun Apr 24 15:11:56 UTC 2016 New revision: 413944 URL: https://svnweb.freebsd.org/changeset/ports/413944 Log: Update to upstream version 0.10.5, turning FDK_AAC into an OPTION PR: 208334 Submitted by: woodsb02@gmail.com Reviewed by: riggs, jbeich Differential Revision: https://reviews.freebsd.org/D6077 Changes: head/multimedia/handbrake/Makefile head/multimedia/handbrake/distinfo |