Bug 208338

Summary: [New Port] devel/gvp: Go Versioning Manager
Product: Ports & Packages Reporter: lukejee
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Only Me CC: riggs
Priority: --- Keywords: needs-qa, patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
shar file
none
new shar file none

Description lukejee 2016-03-27 17:56:38 UTC
Created attachment 168697 [details]
shar file

Go Versioning Manager

gvp stands for Go Versioning Packager and is based on gst a similar tool
that provides dependency isolation for Ruby gems.

The tool modifies your GOPATH to point to a local .godeps/ directory so 
that you can keep the dependencies of your project isolated there, 
it also modifies GOBIN and PATH to include the new GOPATH/bin directory.

gvp is a companion tool to gpm but both tools can be used independently
from each other.

https://github.com/pote/gvp


portlint passed.
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2016-04-10 09:27:34 UTC
Have a look at the comments regarding the Makefile in bug 208053, they apply here as well. Also:
- Why is include pre/post necessary? There are no tests for variables.
- bash is extended with ${PREFIX} while in bug 208053 /usr/bin/env bash is used. Would it make sense to use the same in both ports?

A general remark: If you provide poudriere build logs, your submissions will receive attention quicker.

Could you prepare an updated shar? Thanks in advance.
Comment 2 lukejee 2016-04-11 05:58:55 UTC
Created attachment 169176 [details]
new shar file

Thank you Thomas, i've update the new Makefile
Comment 3 lukejee 2016-04-11 06:19:14 UTC
ok, i will learn how to use poudriere, thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-04-11 19:07:06 UTC
A commit references this bug:

Author: riggs
Date: Mon Apr 11 19:06:05 UTC 2016
New revision: 413083
URL: https://svnweb.freebsd.org/changeset/ports/413083

Log:
  Add devel/gvp, a versioning manager for modules written in Go (lang/go)

  PR:		208338
  Submitted by:	lukejee@gmail.com (maintainer)

Changes:
  head/devel/Makefile
  head/devel/gvp/
  head/devel/gvp/Makefile
  head/devel/gvp/distinfo
  head/devel/gvp/pkg-descr
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2016-04-11 19:14:43 UTC
Yep, poudriere is the tool that will help you save the day many times. A step by step tutorial is included in the porter's handbook:
https://www.freebsd.org/doc/en/books/porters-handbook/testing-poudriere.html

By the way, since poudriere runs stage-qa automatically during a testport run, it would also have told you that you heed USES=shebangfix in gvp's Makefile :-)

No worries, though. Since it was a minimal change, I took the liberty of fixing it before committing.

Continue to have fun with Go and take care of your ports :)