Bug 208625

Summary: PATCH: mountcritremote: mount -d output format change regression
Product: Base System Reporter: corsmith
Component: confAssignee: freebsd-bugs mailing list <bugs>
Status: New ---    
Severity: Affects Some People Keywords: patch
Priority: ---    
Version: 10.3-RELEASE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
mountcritremote patch none

Description corsmith 2016-04-08 00:54:31 UTC
Created attachment 169096 [details]
mountcritremote patch

At some point the output format of mount -d changed from:

mount_tmpfs ...

to:

mount -t tmpfs

This had a side effect of causing mountcritremote to no longer notice when there were remote file system types that needed mounting.  The current check looks like:

case "`mount -d -a -t ${fstype}`" in
*mount_${fstype}*)
	echo -n "Mounting ${fsdecr} file systems:"

There is no _ in the current output so this will never match.

The attached patch simply checks if there is any output re-using the existing idiom earlier in the script to maintain consistency.

The new check looks like:

case "`mount -d -a -t ${fstype}`" in
'')
	;;
*)
	echo -n "Mounting ${fsdecr} file systems:"