Bug 208841

Summary: games/el: Fix build with libc++ 3.8.0
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Some People CC: pi
Priority: --- Flags: pi: maintainer-feedback-
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 208158    
Attachments:
Description Flags
Fix type for abs() calls in games/el none

Description Dimitry Andric freebsd_committer 2016-04-16 20:11:17 UTC
Created attachment 169378 [details]
Fix type for abs() calls in games/el

During the exp-run in bug 208158, it was found that games/el gives errors with libc++ 3.8.0 [1]:

icon_window.cpp:361:8: error: call to 'abs' is ambiguous
                        if (abs(SDL_GetTicks() - last_flash_change) > 250)
                            ^~~

This is because abs() is being called with unsigned arguments.  Fix this in a few places by casting the argument to the appropriate signed type.

[1] http://package18.nyi.freebsd.org/data/headamd64PR208158-default/2016-03-22_18h30m05s/logs/errors/el-193_5.log
Comment 1 Kurt Jaeger freebsd_committer 2016-04-29 21:55:13 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2016-04-29 21:55:53 UTC
A commit references this bug:

Author: pi
Date: Fri Apr 29 21:55:11 UTC 2016
New revision: 414296
URL: https://svnweb.freebsd.org/changeset/ports/414296

Log:
  games/el: Fix build with libc++ 3.8.0

  PR:		208841
  Submitted by:	dim
  Approved by:	acm (maintainer timeout)

Changes:
  head/games/el/files/patch-icon__window.cpp
  head/games/el/files/patch-item__lists.cpp
  head/games/el/files/patch-quest__log.cpp