Bug 208843

Summary: graphics/cuneiform: Fix build with libc++ 3.8.0
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Some People CC: samm
Priority: --- Flags: bugzilla: maintainer-feedback? (samm)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 208158    
Attachments:
Description Flags
Fix argument type for abs() in graphics/cuneiform none

Description Dimitry Andric freebsd_committer 2016-04-16 20:38:26 UTC
Created attachment 169380 [details]
Fix argument type for abs() in graphics/cuneiform

During the exp-run in bug 208158, it was found that graphics/cuneiform gives errors with libc++ 3.8.0 [1]:

/wrkdirs/usr/ports/graphics/cuneiform/work/cuneiform-linux-1.1.0/cuneiform_src/Kern/rimage/sources/main/cricontrol.cpp:597:32: error: call to 'abs' is ambiguous
        wNewHeight = (mbMarginsFlag ? abs(mrMargins.rmBottomMarg - mrMargins.rmTopMarg) : mpSourceDIB->GetLinesNumber());
                                      ^~~

This is because abs() is being called an unsigned argument.  Fix this by casting the argument to the appropriate signed type.

[1] http://package18.nyi.freebsd.org/data/headamd64PR208158-default/2016-03-22_18h30m05s/logs/errors/cuneiform-1.1.0_4.log
Comment 1 Oleksii Samorukov freebsd_committer 2016-04-17 07:13:46 UTC
Thank you for the patch, approved
Comment 2 commit-hook freebsd_committer 2016-04-18 19:03:11 UTC
A commit references this bug:

Author: dim
Date: Mon Apr 18 19:02:56 UTC 2016
New revision: 413606
URL: https://svnweb.freebsd.org/changeset/ports/413606

Log:
  MFH: r413510

  During the exp-run in bug 208158, it was found that graphics/cuneiform
  gives errors with libc++ 3.8.0:

  cuneiform_src/Kern/rimage/sources/main/cricontrol.cpp:597:32: error: call to 'abs' is ambiguous
          wNewHeight = (mbMarginsFlag ? abs(mrMargins.rmBottomMarg - mrMargins.rmTopMarg) : mpSourceDIB->GetLinesNumber());
                                        ^~~

  This is because abs() is being called an unsigned argument.  Fix this by
  casting the argument to the appropriate signed type.

  Approved by:	portmgr (junovitch)
  PR:		208843

Changes:
_U  branches/2016Q2/
  branches/2016Q2/graphics/cuneiform/files/