Summary: | mail/thunderbird: Fail to build when LIBPROXY option is enabled | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Ting-Wei Lan <lantw44> | ||||||||||||
Component: | Individual Port(s) | Assignee: | freebsd-gecko (Nobody) <gecko> | ||||||||||||
Status: | Closed FIXED | ||||||||||||||
Severity: | Affects Only Me | CC: | dominik.muth, w.schwarzenfeld | ||||||||||||
Priority: | --- | ||||||||||||||
Version: | Latest | ||||||||||||||
Hardware: | Any | ||||||||||||||
OS: | Any | ||||||||||||||
See Also: | https://bugzilla.mozilla.org/show_bug.cgi?id=1243312 | ||||||||||||||
Attachments: |
|
The same problem also happens when building www/libxul. mail/thunderbird/work/thunderbird-45.0/mozilla/toolkit/system/unixproxy/nsLibProxySettings.cpp misses #include "nsNetUtil.h" same for www/libxul/work/firefox-45.1.0esr/toolkit/system/unixproxy/nsLibProxySettings.cpp Created attachment 169646 [details]
patch-thunderbird-nsLibProxySettings_cpp
Created attachment 169647 [details]
patch-libxul-nsLibProxySettings_cpp
Created attachment 169648 [details]
patch-libxul-nsLibProxySettings_cpp
Correct it.
Created attachment 169668 [details]
poudriere-thunderbird-success.log
Comment on attachment 169646 [details] patch-thunderbird-nsLibProxySettings_cpp nsNetUtil.h line was removed intentionally. Better use upstream fix, so it can be dropped later. https://hg.mozilla.org/mozilla-central/rev/cf774875a1f4 https://hg.mozilla.org/mozilla-central/rev/23226470bb94 A commit references this bug: Author: jbeich Date: Mon Apr 25 16:19:14 UTC 2016 New revision: 414020 URL: https://svnweb.freebsd.org/changeset/ports/414020 Log: gecko: unbreak build with LIBPROXY=on PR: 208855 Reported by: Ting-Wei Lan, Walter Schwarzenfeld Submitted by: cmt via r401981 Changes: head/mail/thunderbird/files/patch-bug1243312 head/www/firefox/files/patch-bug1243312 head/www/firefox/files/patch-toolkit_system_unixproxy_nsLibProxySettings.cpp head/www/firefox-esr/files/patch-bug1243312 head/www/libxul/files/patch-bug1243312 head/www/seamonkey/files/patch-bug1243312 head/www/seamonkey/files/patch-toolkit_system_unixproxy_nsLibProxySettings.cpp A commit references this bug: Author: jbeich Date: Mon Apr 25 16:26:46 UTC 2016 New revision: 414021 URL: https://svnweb.freebsd.org/changeset/ports/414021 Log: MFH: r414020 gecko: unbreak build with LIBPROXY=on PR: 208855 Reported by: Ting-Wei Lan, Walter Schwarzenfeld Submitted by: cmt via r401981 Approved by: ports-secteam "build fix" blanket Changes: _U branches/2016Q2/ branches/2016Q2/mail/thunderbird/files/patch-bug1243312 branches/2016Q2/www/firefox/files/patch-bug1243312 branches/2016Q2/www/firefox/files/patch-toolkit_system_unixproxy_nsLibProxySettings.cpp branches/2016Q2/www/firefox-esr/files/patch-bug1243312 branches/2016Q2/www/libxul/files/patch-bug1243312 branches/2016Q2/www/seamonkey/files/patch-bug1243312 branches/2016Q2/www/seamonkey/files/patch-toolkit_system_unixproxy_nsLibProxySettings.cpp |
Created attachment 169393 [details] Thunderbird 45.0 build log on FreeBSD 10 Please see the attached build log. The most important error message is: /wrkdirs/usr/ports/mail/thunderbird/work/thunderbird-45.0/mozilla/toolkit/system/unixproxy/nsLibProxySettings.cpp:129:5: error: use of undeclared identifier 'NS_SYSTEMPROXYSETTINGS_CONTRACTID' { NS_SYSTEMPROXYSETTINGS_CONTRACTID, &kNS_UNIXSYSTEMPROXYSERVICE_CID }, ^ 2 warnings and 1 error generated. /wrkdirs/usr/ports/mail/thunderbird/work/thunderbird-45.0/mozilla/config/rules.mk:956: recipe for target 'nsLibProxySettings.o' failed gmake[5]: *** [nsLibProxySettings.o] Error 1