Bug 208996

Summary: [PATCH] sysutils/ansible: make service module respect the sleep option
Product: Ports & Packages Reporter: Guido Falsi <madpilot>
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Only Me CC: lifanov
Priority: --- Keywords: patch
Version: LatestFlags: madpilot: maintainer-feedback+
Hardware: Any   
OS: Any   
URL: https://github.com/ansible/ansible-modules-core/pull/3525
Attachments:
Description Flags
patch
none
Make FreeBSD subclass respect the sleep option. lifanov: maintainer-approval+

Description Guido Falsi freebsd_committer freebsd_triage 2016-04-23 14:34:15 UTC 
Created attachment 169599 [details]
patch

Hi, I found out I need the sleep options in a few cases on FreeBSD when starting/stopping services, so I slightly modified the module implementation.

I think this could be useful for others too.

I also already submitted a pull request upstream for this:

https://github.com/ansible/ansible-modules-core/pull/3525


Thanks!
Comment 1 Nikolai Lifanov 2016-04-23 14:55:22 UTC 
Created attachment 169601 [details]
Make FreeBSD subclass respect the sleep option.

I approve of the change.

However, please use this patch instead. Otherwise the change also applies to
sysutils/ansible1, where I really don't want to carry local patches.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2016-04-23 22:09:40 UTC 
(In reply to Nikolai Lifanov from comment #1)
> Created attachment 169601 [details]
> Make FreeBSD subclass respect the sleep option.
> 
> I approve of the change.
> 
> However, please use this patch instead. Otherwise the change also applies to
> sysutils/ansible1, where I really don't want to carry local patches.

Sure, You're right.

I'll commit your patch.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2016-04-23 22:20:12 UTC 
Committed. Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-04-23 22:20:52 UTC 
A commit references this bug:

Author: madpilot
Date: Sat Apr 23 22:19:51 UTC 2016
New revision: 413917
URL: https://svnweb.freebsd.org/changeset/ports/413917

Log:
  Make the service module respect the sleep option.

  PR:		208996
  Submitted by:	me
  Approved by:	Nikolai Lifanov <lifanov at mail.lifanov.com>
  		(maintainer)

Changes:
  head/sysutils/ansible/Makefile
  head/sysutils/ansible/files/extra-patch-8aac5ae