Bug 209008

Summary: security/p5-Dancer2-Plugin-Auth-Extensible-Provider-DBIC: Fix plist
Product: Ports & Packages Reporter: Henk van Oers <hvo.pm>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: lme
Priority: --- Keywords: patch
Version: LatestFlags: hvo.pm: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
The diff
none
The diff
hvo.pm: maintainer-approval+
The new diff with @comment hvo.pm: maintainer-approval+

Description Henk van Oers 2016-04-24 08:19:32 UTC
Created attachment 169622 [details]
The diff

The README is not a provider.
Comment 1 Henk van Oers 2016-04-24 08:25:43 UTC
Comment on attachment 169622 [details]
The diff

sorry wrong diff
Comment 2 Henk van Oers 2016-04-24 08:31:09 UTC
Created attachment 169623 [details]
The diff
Comment 3 Henk van Oers 2016-05-04 13:36:00 UTC
OK, my subject line and attachment were a mess,
but is it OK now?
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2016-05-09 11:04:01 UTC
Yes. But you probably need to mask the files with @comment to avoid stage-qa errors caused by staged files not listed in plist.

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%SITE_PERL%%/Dancer2/Plugin/Auth/Extensible/Provider/README.pod
Error: Orphaned: %%PERL5_MAN3%%/Dancer2::Plugin::Auth::Extensible::Provider::README.3.gz
===> Checking for items in pkg-plist which are not in STAGEDIR
Comment 5 Henk van Oers 2016-05-27 22:02:08 UTC
Created attachment 170737 [details]
The new diff with @comment

Also a timestamp in the distinfo.
The new QA tests and 'make check-plist' and deleting/installing are OK.
Comment 6 VK 2016-05-28 09:10:27 UTC
Thanks for the report. Question, jumping from no PORTREVISION to PORTREVISION=2. Did you mean PORTREVISION=1 ?
Comment 7 Henk van Oers 2016-05-28 18:03:01 UTC
(In reply to Vladimir Krstulja from comment #6)
The first patch was wrong and has number 1.
This one is patch number 2.
But you can call it the first good one :-)
Comment 8 VK 2016-05-28 19:06:10 UTC
But it was not committed. PORTREVISION does not track suggested patches, it's not a "patch number", but the state of the port in the HEAD. You increase PORTREVISION when you make significant changes to the port resulting with different contents of the built package, but the version of the software the pkg is packaging remains unchanged. Maybe I'm nitpicking, a committer will correct me, I just like things to be by the numbers, hence my observation.
Comment 9 Henk van Oers 2016-05-30 23:59:37 UTC
I am no longer interested in this port.
Who wants to take over?
Comment 10 VK 2016-05-31 08:08:51 UTC
Henk, I'm sorry feel this way. I hope it's not something I said. :)

In the interest of properly documenting this issue, I wouldn't call it FIXED. But before it's closed, I'd like to ask committers if your latest patch can be applied anyway.

Dmitry? Please note PORTREVISION was bumped from 0 to 2.
Comment 11 Henk van Oers 2016-05-31 08:12:53 UTC
(In reply to Vladimir Krstulja from comment #10)
It's in the tree now with PORTREVISION 1
Comment 12 VK 2016-05-31 08:53:55 UTC
My apologies, indeed it is. I wonder why the commit hook never updated this bug report. For the reference:

https://svnweb.freebsd.org/ports?view=revision&revision=416157