Bug 209054

Description Joseph Mingrone 2016-04-25 19:31:41 UTC

Created attachment 169695 [details]
svn diff to upgrade to 25.0.93 and modernize option handling

portlint: OK
testport: OK (poudriere: 9.3-RELEASE-p36, i386,  default options / no ACL,DBUS,X11 / all off) [1]
testport: OK (poudriere: 9.3-RELEASE-p30, amd64, default options / no ACL,DBUS,X11 / all off) [2]
testport: OK (poudriere: 10.3-RELEASE,    i386,  default options / no ACL,DBUS,X11 / all off) [3]
testport: OK (poudriere: 10.3-RELEASE,    amd64, default options / no ACL,DBUS,X11 / all off) [4]

Most of the proposed changes deal with how options are handled.

1. Reorganize the options so they are logically grouped.  The advantage is that it's clearer for users to determine what major dependencies will be pulled in.

2. Reduce the number of build-stoppage points by using OPT_IMPLIES=.  With these changes, there is only one way the user can configure the port so that it can't build: choosing X11, but not selecting an X11 toolkit.

3. Add the ability to use FreeBSD's kqueue file notification and make this the default.  Using file notification via gfile did not work for me.  Maybe it requires some Gnome dependency?

A note about portlint -AC and stage-qa warnings for non-X11 installations:

When X11 and all X11-implying options are turned off, the port will require as few as one run-time dependency (print/indexinfo).

To prevent warnings and to minimize clutter for non-X11 installations, we could not install and deal with the icons and emacs.desktop file.  INSTALLS_ICONS=YES and devel/desktop-file-utils pull in many dependencies that most non-X11 users will not want.  However, some users running a desktop environment may want to install without X11.  For this rare case, these dependencies will likely already be pulled in.  So, it's a reasonable compromise to install those files even for non-X11 installations, but to not handle them with INSTALLS_ICONS=YES and devel/desktop-file-utils for non-X11 installations.  The consequence is that portlint -AC will warn about INSTALL_ICONS and stage-qa will warn about devel/desktop-file-utils.


[1]
http://pkg.awarnach.mathstat.dal.ca/data/9i386-default/2016-04-25_15h27m14s/logs/emacs-devel-25.0.93,2.log
http://pkg.awarnach.mathstat.dal.ca/data/9i386-default/2016-04-25_15h46m27s/logs/emacs-devel-25.0.93,2.log
http://pkg.awarnach.mathstat.dal.ca/data/9i386-default/2016-04-25_15h46m27s/logs/emacs-devel-25.0.93,2.log

[2]
http://pkg.awarnach.mathstat.dal.ca/data/9amd64-default/2016-04-25_15h33m52s/logs/emacs-devel-25.0.93,2.log
http://pkg.awarnach.mathstat.dal.ca/data/9amd64-default/2016-04-25_15h49m29s/logs/emacs-devel-25.0.93,2.log
http://pkg.awarnach.mathstat.dal.ca/data/9amd64-default/2016-04-25_15h49m29s/logs/emacs-devel-25.0.93,2.log

[3]
http://pkg.awarnach.mathstat.dal.ca/data/103i386-default/2016-04-25_15h38m40s/logs/emacs-devel-25.0.93,2.log
http://pkg.awarnach.mathstat.dal.ca/data/103i386-default/2016-04-25_15h52m57s/logs/emacs-devel-25.0.93,2.log
http://pkg.awarnach.mathstat.dal.ca/data/103i386-default/2016-04-25_16h05m26s/logs/emacs-devel-25.0.93,2.log

[4]
http://pkg.awarnach.mathstat.dal.ca/data/103amd64-default/2016-04-25_15h42m51s/logs/emacs-devel-25.0.93,2.log
http://pkg.awarnach.mathstat.dal.ca/data/103amd64-default/2016-04-25_15h56m32s/logs/emacs-devel-25.0.93,2.log
http://pkg.awarnach.mathstat.dal.ca/data/103amd64-default/2016-04-25_16h08m46s/logs/emacs-devel-25.0.93,2.log