Bug 209057

Summary: graphics/osg-devel: Update to 3.5.1 and fix build with ffmpeg 3.0.x
Product: Ports & Packages Reporter: Ben Woods <woodsb02>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me CC: adamw, amdmi3, multimedia, woodsb02
Priority: --- Keywords: patch, patch-ready
Version: LatestFlags: amdmi3: maintainer-feedback+
Hardware: Any   
OS: Any   
URL: http://www.openscenegraph.org/index.php/download-section/developer-releases/208-openscenegraph-3-5-1-developer-release
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209056
Bug Depends on:    
Bug Blocks: 207547    
Attachments:
Description Flags
Patch to update graphics/osg-devel to 3.5.1 and fix build with ffmpeg 3.0.x
woodsb02: maintainer-approval? (amdmi3)
QA: Successful poudriere testport logs for graphics/osg-devel 3.5.1 with ffmpeg3 patch with all options DISABLED against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 10.3 amd64 (gzipped)
none
QA: Successful poudriere testport logs for graphics/osg-devel 3.5.1 with ffmpeg3 patch with all options ENABLED (QT4) against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 10.3 amd64 (gzipped)
none
QA: Successful poudriere testport logs for graphics/osg-devel 3.5.1 with ffmpeg3 patch with all options ENABLED (QT5) against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 10.3 amd64 (gzipped)
none
QA: Successful poudriere testport logs for graphics/osg-devel 3.5.1 with ffmpeg3 patch with all options ENABLED (QT5) against FFmpeg 3.0.1 (from PR 207547) on FreeBSD 11 amd64 (gzipped) none

Description Ben Woods freebsd_committer 2016-04-25 21:40:36 UTC
Created attachment 169702 [details]
Patch to update graphics/osg-devel to 3.5.1 and fix build with ffmpeg 3.0.x

graphics/osg-devel:
- Update to 3.5.1
- Add option to choose build with QT4 or QT5 (both disabled by default)
- Mark Gstreamer option as broken, as build fails with error cannot find -lgstreamer-1.0
- Convert to option helpers, tidy up
- Add patch to allow osg to build successfully once multimedia/ffmpeg is updated to 3.0.x. Note that multimedia/ffmpeg is currently still on the 2.8.x branch, however this patch is backwards compatible with ffmpeg 2.8.x.

Changes this release:
  http://www.openscenegraph.org/index.php/download-section/developer-releases/208-openscenegraph-3-5-1-developer-release
Comment 1 Ben Woods freebsd_committer 2016-04-25 21:42:35 UTC
Created attachment 169703 [details]
QA: Successful poudriere testport logs for graphics/osg-devel 3.5.1 with ffmpeg3 patch with all options DISABLED against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 10.3 amd64 (gzipped)
Comment 2 Ben Woods freebsd_committer 2016-04-26 06:41:51 UTC
Created attachment 169706 [details]
QA: Successful poudriere testport logs for graphics/osg-devel 3.5.1 with ffmpeg3 patch with all options ENABLED (QT4) against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 10.3 amd64 (gzipped)
Comment 3 Ben Woods freebsd_committer 2016-04-26 16:53:00 UTC
Created attachment 169723 [details]
QA: Successful poudriere testport logs for graphics/osg-devel 3.5.1 with ffmpeg3 patch with all options ENABLED (QT5) against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 10.3 amd64 (gzipped)
Comment 4 Ben Woods freebsd_committer 2016-04-26 16:57:36 UTC
Created attachment 169724 [details]
QA: Successful poudriere testport logs for graphics/osg-devel 3.5.1 with ffmpeg3 patch with all options ENABLED (QT5) against FFmpeg 3.0.1 (from PR 207547) on FreeBSD 11 amd64 (gzipped)
Comment 6 Ben Woods freebsd_committer 2016-06-09 11:26:38 UTC
Hi Dmitry,
Just a reminder, that this PR for osg-devel is also outstanding.
Thanks,
Ben
Comment 7 Dmitry Marakasov freebsd_committer 2016-06-09 12:15:45 UTC
Yes, this is in the queue, shouldn't take much time as it should be similar to osg and has no consumers.
Comment 8 Ben Woods freebsd_committer 2016-07-30 08:17:46 UTC
Bump. Any progress on this Dmitry?
Comment 9 commit-hook freebsd_committer 2016-12-11 15:24:01 UTC
A commit references this bug:

Author: jbeich
Date: Sun Dec 11 15:23:17 UTC 2016
New revision: 428354
URL: https://svnweb.freebsd.org/changeset/ports/428354

Log:
  graphics/osg-devel: declare as BROKEN

  src/osgPlugins/ffmpeg/FFmpegDecoderAudio.cpp:230:20: error: no member named 'get_buffer' in 'AVCodecContext'; did you mean 'get_buffer2'?
          m_context->get_buffer = avcodec_default_get_buffer;
                     ^~~~~~~~~~
                     get_buffer2
  /usr/local/include/libavcodec/avcodec.h:2593:11: note: 'get_buffer2' declared here
      int (*get_buffer2)(struct AVCodecContext *s, AVFrame *frame, int flags);
            ^
  src/osgPlugins/ffmpeg/FFmpegDecoderAudio.cpp:230:33: error: use of undeclared identifier 'avcodec_default_get_buffer'; did you mean 'avcodec_default_get_buffer2'?
          m_context->get_buffer = avcodec_default_get_buffer;
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
                                  avcodec_default_get_buffer2
  /usr/local/include/libavcodec/avcodec.h:4651:5: note: 'avcodec_default_get_buffer2' declared here
  int avcodec_default_get_buffer2(AVCodecContext *s, AVFrame *frame, int flags);
      ^
  src/osgPlugins/ffmpeg/FFmpegDecoderAudio.cpp:231:20: error: no member named 'release_buffer' in 'AVCodecContext'
          m_context->release_buffer = avcodec_default_release_buffer;
          ~~~~~~~~~  ^
  src/osgPlugins/ffmpeg/FFmpegDecoderAudio.cpp:231:37: error: use of undeclared identifier 'avcodec_default_release_buffer'; did you mean 'avcodec_default_get_buffer2'?
          m_context->release_buffer = avcodec_default_release_buffer;
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                      avcodec_default_get_buffer2
  /usr/local/include/libavcodec/avcodec.h:4651:5: note: 'avcodec_default_get_buffer2' declared here
  int avcodec_default_get_buffer2(AVCodecContext *s, AVFrame *frame, int flags);
      ^

  PR:		209057
  Reported by:	antoine (via exp-run)

Changes:
  head/graphics/osg-devel/Makefile
Comment 10 commit-hook freebsd_committer 2016-12-27 14:49:43 UTC
A commit references this bug:

Author: amdmi3
Date: Tue Dec 27 14:49:11 UTC 2016
New revision: 429620
URL: https://svnweb.freebsd.org/changeset/ports/429620

Log:
  - Update to 3.5.1
  - Fix build with recent ffmpeg
  - Reduce diff with graphics/osg

  PR:		209057
  Submitted by:	woodsb02@gmail.com

Changes:
  head/graphics/osg-devel/Makefile
  head/graphics/osg-devel/distinfo
  head/graphics/osg-devel/files/patch-CMakeModules_FindGStreamer.cmake
  head/graphics/osg-devel/files/patch-ffmpeg3
  head/graphics/osg-devel/files/patch-include_osgViewer_View
  head/graphics/osg-devel/files/patch-src_osgPlugins_ffmpeg_CMakeLists.txt
  head/graphics/osg-devel/files/patch-src_osgPlugins_gdal_CMakeLists.txt
  head/graphics/osg-devel/files/patch-src_osgPlugins_nvtt_CMakeLists.txt
  head/graphics/osg-devel/files/patch-src_osgPlugins_ogr_CMakeLists.txt
  head/graphics/osg-devel/pkg-plist