Bug 209108

Summary: x11/fbdesk: Fix build with libc++ 3.8.0
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Some People CC: pi
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 208158    
Attachments:
Description Flags
Fix type for abs() call in x11/fbdesk none

Description Dimitry Andric freebsd_committer 2016-04-27 18:01:36 UTC

    
Comment 1 Dimitry Andric freebsd_committer 2016-04-27 18:03:08 UTC
Created attachment 169765 [details]
Fix type for abs() call in x11/fbdesk

During the exp-run in bug 208158, it was found that x11/fbdesk gives errors with libc++ 3.8.0 [1]:

TextBox.cc:202:19: error: call to 'abs' is ambiguous
            tmp = abs(event.x - font().textWidth(m_text.c_str() + m_start_pos, i - m_start_pos));
                  ^~~

This is because abs() is being called with unsigned arguments.  Fix this by casting the arguments to the appropriate signed type.

[1] http://package18.nyi.freebsd.org/data/headamd64PR208158-default/2016-03-22_18h30m05s/logs/errors/fbdesk-1.4.1_6.log
Comment 2 commit-hook freebsd_committer 2016-04-30 04:40:03 UTC
A commit references this bug:

Author: pi
Date: Sat Apr 30 04:39:51 UTC 2016
New revision: 414329
URL: https://svnweb.freebsd.org/changeset/ports/414329

Log:
  x11/fbdesk: Fix build with libc++ 3.8.0

  PR:		209108
  Submitted by:	dim

Changes:
  head/x11/fbdesk/files/patch-TextBox.cc
Comment 3 Kurt Jaeger freebsd_committer 2016-04-30 04:40:10 UTC
Committed, thanks!