Bug 209148

Summary: [patch] net-im/teamwords: drop unused dependencies, add WEBKITNOTIFY option
Product: Ports & Packages Reporter: Andriy Voskoboinyk <avos>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me CC: w.schwarzenfeld
Priority: --- Keywords: patch
Version: LatestFlags: tobik: maintainer-feedback-
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Makefile.diff
none
portlint.log
none
poudriere-10.3-amd64-default.log
none
poudriere-9.3-i386-default.log
none
poudriere-10.3-amd64-webkitnotify.log
none
poudriere-9.3-i386-webkitnotify.log none

Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-04-29 10:17:02 UTC
Created attachment 169803 [details]
Makefile.diff

- Drop qt5-x11extras, qt5-svg, qt5-linguist dependencies; use qt5-buildtools for build time only.
 * Add qt5-webkit and qt5-widgets as a runtime dependencies; they were hidden by qt5-linguist previously.
- Allow to change notifications style via WEBKITNOTIFY option.
- Pet portlint (use tab instead of spaces for variable assignment).
- Bump PORTREVISION.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-04-29 10:17:30 UTC
Created attachment 169804 [details]
portlint.log
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-04-29 10:18:06 UTC
Created attachment 169805 [details]
poudriere-10.3-amd64-default.log
Comment 3 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-04-29 10:18:54 UTC
Created attachment 169806 [details]
poudriere-9.3-i386-default.log
Comment 4 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-04-29 10:19:21 UTC
Created attachment 169807 [details]
poudriere-10.3-amd64-webkitnotify.log
Comment 5 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-04-29 10:19:49 UTC
Created attachment 169808 [details]
poudriere-9.3-i386-webkitnotify.log
Comment 6 Walter Schwarzenfeld 2018-01-13 06:30:12 UTC
9.3 is gone. 
Maintainer feedback?
Comment 7 commit-hook freebsd_committer freebsd_triage 2019-01-27 04:41:56 UTC
A commit references this bug:

Author: tobik
Date: Sun Jan 27 04:41:47 UTC 2019
New revision: 491325
URL: https://svnweb.freebsd.org/changeset/ports/491325

Log:
  net-im/teamwords: Allow to change notification style via WEBKITNOTIFY option

  - Drop qt5-x11extras, qt5-svg, qt5-linguist dependencies; use
    qt5-buildtools for build time only
  - Add qt5-webkit and qt5-widgets as explicit runtime dependencies;
    they were most likely hidden by qt5-linguist previously
  - Fix some tabs vs spaces issue
  - Reset maintainership due to the long timeout

  PR:		209148
  Submitted by:	avos
  Approved by:	kmoore (maintainer timeout, ~33 months)

Changes:
  head/net-im/teamwords/Makefile