Bug 209163
| Summary: | x11-toolkits/linux-c6-qt47-x11 and graphics/linux-c6-glx-utils RUN_DEPENDS missing USE_LINUX variable | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | marc.priggemeyer |
| Component: | Individual Port(s) | Assignee: | Tijl Coosemans <tijl> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | xmj |
| Priority: | --- | Keywords: | needs-qa, patch-ready |
| Version: | Latest | Flags: | xmj:
maintainer-feedback+
|
| Hardware: | Any | ||
| OS: | Any | ||
| Attachments: | |||
Created attachment 169825 [details]
Unified diff for x11-toolkits/linux-c6-qt47-x11
Thanks for submitting it, your patch clearly works. I'll take a look if there isn't a way to leverage the ports framework's options glue to see if you can do something like NVIDIA_GL_USE_LINUX_APPS+= libglu Thanks, Johannes (In reply to Johannes Jost Meixner from comment #2) > leverage the ports framework's options glue That's beyond my knowledge, I fear. But nevertheless a good idea to have a more ports-centric mechanism to add features. (In reply to marc.priggemeyer from comment #3) Can you try the following please (exemplary for glx-utils)? NVIDIA_GL_RUN_DEPENDS= ${LINUXBASE}/usr/lib/libGL.so.1:x11/nvidia-driver NVIDIA_GL_VARS= USE_LINUX_APPS+=libglu Thanks to mat@ I now know that ${opt}_VARS allows to set custom variables, and USE_LINUX_APPS provides the abstraction for the RUN_DEPENDS we set conditionally for NVIDIA_GL. (In reply to Johannes Jost Meixner from comment #4) Here's the output generated by poudriere: ===> linux-c6_64-glx-utils-10.4.3 depends on file: /compat/linux/usr/lib64/libGLU.so.1 - not found ===> Installing existing package /packages/All/linux-c6_64-libGLU-10.4.3.txz Build process was successful with those settings. (In reply to marc.priggemeyer from comment #5) Great. Would you mind attaching the new diffs and the runs of poudriere testport, please? (In reply to Johannes Jost Meixner from comment #6) Please see the attachments. I'm wondering about these lines: "It looks like the /compat/linux/usr/lib64/libGLU.so.1:/usr/ports/graphics/linux-c6-libGLU depends line has an absolute port origin, make sure to remove ${PORTSDIR}/ from it." It appears that in Mk/bsd.linux-apps.mk ${PORTSDIR} is prepended to all linux ports dependencies. For a test (see below), removing it once from the line for the libGLU dependency results in a successful build and no warning message. Could ${PORTSDIR}/ they be removed for all of them or is there some edge case I did not notice that might break everything? Change libglu_PORT= ${PORTSDIR}/graphics/linux${LINUX_BASEPORT_NAME}-libGLU to libglu_PORT= graphics/linux${LINUX_BASEPORT_NAME}-libGLU in Mk/bsd.linux-apps.mk (New ticket, btw.?) Created attachment 169908 [details]
New unified diff for graphics/linux-c6-glx-utils/Makefile
Created attachment 169909 [details]
log from pourdriere testport run for graphics/linux-c6-glx-utils
Created attachment 169910 [details]
New unified diff for x11-toolkits/linux-c6-qt47-x11/Makefile
Created attachment 169911 [details]
log from poudriere testport for x11-toolkits/linux-c6-qt47-x11
Created attachment 169912 [details]
New unified diff for graphics/linux-c6-glx-utils/Makefile
Created attachment 169913 [details]
New unified diff for x11-toolkits/linux-c6-qt47-x11/Makefile
A commit references this bug: Author: tijl Date: Tue Sep 6 13:42:20 UTC 2016 New revision: 421428 URL: https://svnweb.freebsd.org/changeset/ports/421428 Log: Use infrastructure to depend on Linux libGLU. PR: 209163 Submitted by: marc.priggemeyer@gmail.com Changes: head/graphics/linux-c6-glx-utils/Makefile head/x11-toolkits/linux-c6-qt47-x11/Makefile |
Created attachment 169824 [details] Unified diff for graphics/linux-c6-glx-utils/Makefile While using Poudriere to build linux-c6 with OVERRIDE_LINUX_BASE_PORT=c6_64 OVERRIDE_LINUX_NONBASE_PORTS=c6_64 in make.conf the following error messages are generated: "===> linux-c6_64-qt47-x11-4.7.2_1 depends on package: linux-c6-libGLU>0 - not found" "===> linux-c6_64-glx-utils-10.4.3 depends on package: linux-c6-libGLU>0 - not found" To correctly distinguish between 32bit and 64bit builds the RUN_DEPENDS declarations need to have the USE_LINUX variable used for dependency specification. See attached unified diffs for the Makefiles of both ports.