Summary: | Update usr/bin/host to the latest upstream version to fix IXFR/AXFR handling | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Vitaly Magerya <vmagerya> | ||||||
Component: | bin | Assignee: | Dag-Erling Smørgrav <des> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | des, gonzo, ngie | ||||||
Priority: | --- | Flags: | ngie:
mfc-stable10?
|
||||||
Version: | CURRENT | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Vitaly Magerya
2016-05-01 10:50:57 UTC
Taking bug for validation/port, as noted on hackers@. A commit references this bug: Author: des Date: Thu Jun 9 20:40:12 UTC 2016 New revision: 301759 URL: https://svnweb.freebsd.org/changeset/base/301759 Log: Update to latest upstream version PR: 209177 Reported by: Vitaly Magerya MFC after: 1 week Changes: _U head/contrib/ldns-host/ head/contrib/ldns-host/Makefile head/contrib/ldns-host/ldns-host.1 head/contrib/ldns-host/ldns-host.c des@ did the commit. Reassigning :). Note that I still get FORMERR with your test case: % host -t ixfr x localhost Using domain server: Name: localhost Address: 127.0.0.1#53 Aliases: Host x not found: 1(FORMERR) ; Transfer failed. (I expected NXDOMAIN) I'm not sure where that particular FORMERR comes from (what are you running on your localhost?). An easy way to test the IXFR changes would be this: host -t ixfr zonetransfer.me nsztm1.digi.ninja The previous version showed FORMERR, the current one should show a list of records. (An alternative test method is to set up your own authoritative server, which is what I alluded to with "host -t ixfr x localhost", but that's less convenient given the existence of nsztm1.digi.ninja). * * * I just discovered an unfixed problem with ixfr queries in the new code, namely: $ host -t ixfr=2014101603 zonetransfer.me nsztm1.digi.ninja Using domain server: Name: nsztm1.digi.ninja Address: 81.4.108.41#53 Aliases: zonetransfer.me has SOA record nsztm1.digi.ninja. robin.digi.ninja. 2014101603 172800 900 1209600 3600 ; Transfer failed. Instead of "Transfer failed", host should recognize that this response indicates "no new records since 2014101603". I don't know why I didn't test this case until now. Previous version on 10.3-p3: % host -t ixfr zonetransfer.me nsztm1.digi.ninja Using domain server: Name: nsztm1.digi.ninja Address: 81.4.108.41#53 Aliases: Host zonetransfer.me not found: 9(NOTAUTH) Strange. I see a FORMERR on 10.1-RELEASE-p26 amd64, 11.0-CURRENT i386 (built on 2015-01-11), and 10.3-RELEASE i386. Do you have a DNS-redirecting firewall somewhere in your network maybe? Whatever the case with the old one, the new one should work. Does it? The new one (what's currently in 11.0) works as you described. There is nothing on my network that intercepts DNS traffic; I have FTTH and my own router. Created attachment 171271 [details] ldns-host-06347b1f76fe.diff Hm. I'm out of ideas then. I guess the important part is that the new version works, while the old one didn't. * * * While we're at it, would you commit an update to [1], which fixes the problem from comment 5, or should I submit it separately? [1] http://hg.tx97.net/ldns-host/rev/06347b1f76fe A commit references this bug: Author: des Date: Wed Jul 13 18:26:05 UTC 2016 New revision: 302779 URL: https://svnweb.freebsd.org/changeset/base/302779 Log: merge upstream hg 06347b1f76fe (fix IXFR) PR: 209177 MFC after: 3 days Changes: _U head/contrib/ldns-host/ head/contrib/ldns-host/ldns-host.c A commit references this bug: Author: ngie Date: Thu Jul 14 06:10:16 UTC 2016 New revision: 302807 URL: https://svnweb.freebsd.org/changeset/base/302807 Log: Initialize first_serial to 0 in dozonetransfer(..) to fix -Wuninitialized warning MFC after: 3 days X-MFC with: r302779 Pointyhat to: des PR: 209177 Reported by: Jenkins (sparc64 job), gcc 4.2.1, gcc 5.3.0 Sponsored by: EMC / Isilon Storage Division Changes: head/contrib/ldns-host/ldns-host.c A commit references this bug: Author: eadler Date: Wed Mar 7 11:03:01 UTC 2018 New revision: 330577 URL: https://svnweb.freebsd.org/changeset/base/330577 Log: MFC r302779,r302807: merge upstream hg 06347b1f76fe (fix IXFR) Initialize first_serial to 0 in dozonetransfer(..) to fix -Wuninitialized warning PR: 209177 Changes: _U stable/11/ stable/11/contrib/ldns-host/ldns-host.c There is a commit referencing this PR, but it's still not closed and has been inactive for some time. Closing the PR as fixed but feel free to re-open it if the issue hasn't been completely resolved. Thanks A commit references this bug: Author: rigoletto Date: Sat Mar 7 22:18:28 UTC 2020 New revision: 527985 URL: https://svnweb.freebsd.org/changeset/ports/527985 Log: net/nxproxy: Update to 3.5.99.20-1 PR: 209177 Submitted by: Michael Muenz <m.muenz@gmail.com> Approved by: tcberner (mentor, implicit) Changes: head/net/nxproxy/Makefile head/net/nxproxy/distinfo head/net/nxproxy/files/ head/net/nxproxy/files/patch-configure.ac |