Bug 209260

Summary: [MAINTAINER][PATCH] dns/powerdns: Fix compilation on FreeBSD 9.3 i386
Product: Ports & Packages Reporter: Ralf van der Enden <tremere>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Only Me CC: riggs
Priority: --- Keywords: easy, needs-qa, patch
Version: LatestFlags: riggs: merge-quarterly+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Change std::abs to std::labs
tremere: maintainer-approval+
9.3 i386 buildlog
none
10.3 i386 buildlog
none
10.3 amd64 buildlog none

Description Ralf van der Enden 2016-05-04 10:20:22 UTC
Created attachment 169955 [details]
Change std::abs to std::labs

For some reason 9.3 i386 gets confused overloading std::abs to the correct function. Probably because both cmath and cstdlib are included (which both have std::abs). Changing it to std::labs takes away the confusion.

The only thing I can't wrap my head around is the fact that 10.3 i386 doesn't run into the same issue.
Comment 1 Ralf van der Enden 2016-05-04 10:24:51 UTC
Created attachment 169956 [details]
9.3 i386 buildlog
Comment 2 Ralf van der Enden 2016-05-04 10:25:36 UTC
Created attachment 169957 [details]
10.3 i386 buildlog
Comment 3 Ralf van der Enden 2016-05-04 10:25:58 UTC
Created attachment 169958 [details]
10.3 amd64 buildlog
Comment 4 Ralf van der Enden 2016-05-04 11:03:16 UTC
Since I'm not running on 11-CURRENT I cannot reliably test if this makes compilation on 11-CURRENT break. Poudriere tells me I should create jails with versions above my own system, which is running 10.3-RELEASE-p1
Comment 5 Thomas Zander freebsd_committer 2016-05-04 18:38:49 UTC
No worries, I'll double-check 11-CURRENT.
Comment 6 commit-hook freebsd_committer 2016-05-04 21:05:00 UTC
A commit references this bug:

Author: riggs
Date: Wed May  4 21:04:18 UTC 2016
New revision: 414613
URL: https://svnweb.freebsd.org/changeset/ports/414613

Log:
  Fix build on 9.3 i386

  PR:		209260
  Submitted by:	tremere@cainites.net (maintainer)
  MFH:		2016Q2 (build fix blanket)

Changes:
  head/dns/powerdns/Makefile
  head/dns/powerdns/files/patch-pdns_dnspacket.cc
Comment 7 commit-hook freebsd_committer 2016-05-04 21:13:04 UTC
A commit references this bug:

Author: riggs
Date: Wed May  4 21:12:42 UTC 2016
New revision: 414614
URL: https://svnweb.freebsd.org/changeset/ports/414614

Log:
  MFH: r414613

  Fix build on 9.3 i386

  PR:		209260
  Submitted by:	tremere@cainites.net (maintainer)

  Approved by:	ports-secteam (build fix blanket)

Changes:
_U  branches/2016Q2/
  branches/2016Q2/dns/powerdns/Makefile
  branches/2016Q2/dns/powerdns/files/patch-pdns_dnspacket.cc