Bug 209346

Summary: net/opal: Fix build with ffmpeg 3.0.x
Product: Ports & Packages Reporter: Ben Woods <woodsb02>
Component: Individual Port(s)Assignee: Ben Woods <woodsb02>
Status: Closed FIXED    
Severity: Affects Only Me CC: woodsb02
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (gnome)
Hardware: Any   
OS: Any   
URL: https://git.archlinux.org/svntogit/packages.git/tree/trunk/opal-ffmpeg3.patch?h=packages/opal
Bug Depends on:    
Bug Blocks: 207547    
Attachments:
Description Flags
QA: Successful poudriere testport logs for net/opal with patch against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64 (gzipped)
none
Patch to fix build of net/opal using ffmpeg 3.0.x
none
QA: Successful poudriere testport logs for net/opal with patch against FFmpeg 3.0.1 (from PR 207547) on FreeBSD 11-current amd64 (gzipped) none

Description Ben Woods freebsd_committer freebsd_triage 2016-05-06 22:16:11 UTC 
net/opal: Fix build with ffmpeg 3.0.x

Add patch to allow opal to build successfully once multimedia/ffmpeg is updated to 3.0.x. Note that multimedia/ffmpeg is currently still on the 2.8.x branch, however this patch is backwards compatible with ffmpeg 2.8.x.

Note: this patch was obtained from ArchLinux [1].

  [1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/opal-ffmpeg3.patch?h=packages/opal
Comment 1 Ben Woods freebsd_committer freebsd_triage 2016-05-06 22:18:28 UTC 
Created attachment 170066 [details]
QA: Successful poudriere testport logs for net/opal with patch against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64 (gzipped)
Comment 2 Ben Woods freebsd_committer freebsd_triage 2016-05-06 22:19:58 UTC 
Created attachment 170067 [details]
Patch to fix build of net/opal using ffmpeg 3.0.x
Comment 3 Ben Woods freebsd_committer freebsd_triage 2016-05-06 22:57:58 UTC 
Created attachment 170070 [details]
QA: Successful poudriere testport logs for net/opal with patch against FFmpeg 3.0.1 (from PR 207547) on FreeBSD 11-current amd64 (gzipped)
Comment 4 Ben Woods freebsd_committer freebsd_triage 2016-05-10 08:42:55 UTC 
I will take this bug report, since I now have a commit bit.

Waiting on feedback from gnome@ team.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-05-10 17:50:44 UTC 
A commit references this bug:

Author: woodsb02
Date: Tue May 10 17:50:21 UTC 2016
New revision: 414950
URL: https://svnweb.freebsd.org/changeset/ports/414950

Log:
  net/opal: Fix build with ffmpeg 3.0.x
  - Add patch to allow opal to build successfully once multimedia/ffmpeg
    is updated to 3.0.x. Note that multimedia/ffmpeg is currently still
    on the 2.8.x branch, however this patch is backwards compatible with
    ffmpeg 2.8.x.

  PR:		209346
  Reported by:	antoine (PR207547)
  Reviewed by:	kwm (with gnome hat)
  Approved by:	adamw (mentor)
  Obtained from:	ArchLinux [1]
  Differential Revision:	https://reviews.freebsd.org/D6308

    [1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/opal-ffmpeg3.patch?h=packages/opal

Changes:
  head/net/opal/Makefile
  head/net/opal/files/patch-ffmpeg3