Bug 209348

Summary: multimedia/libquicktime: Fix build with ffmpeg 3.0.x
Product: Ports & Packages Reporter: Ben Woods <woodsb02>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Only Me CC: multimedia
Priority: --- Keywords: patch, patch-ready
Version: Latest   
Hardware: Any   
OS: Any   
URL: http://sources.debian.net/patches/libquicktime/2:1.2.4-8/
Bug Depends on:    
Bug Blocks: 207547    
Attachments:
Description Flags
Patch to fix build of multimedia/libquicktime using ffmpeg 3.0.x
woodsb02: maintainer-approval+
QA: Successful poudriere testport logs for multimedia/libquicktime with patch against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64
none
QA: Successful poudriere testport logs for multimedia/libquicktime with patch against FFmpeg 3.0.1 (from PR 207547) on FreeBSD 11-current amd64 none

Description Ben Woods freebsd_committer freebsd_triage 2016-05-06 23:05:59 UTC 
Created attachment 170071 [details]
Patch to fix build of multimedia/libquicktime using ffmpeg 3.0.x

multimedia/libquicktime: Fix build with ffmpeg 3.0.x

Add patches to allow libquicktime to build successfully once multimedia/ffmpeg is updated to 3.0.x. Note that multimedia/ffmpeg is currently still on the 2.8.x branch, however these patches are backwards compatible with ffmpeg 2.8.x.

Note: these patches were obtained from Debian [1], and since they overlapped with the existing patch-ffmpeg2 in the FreeBSD ports tree, the existing patch was removed in favour of Debian's more complete ffmpeg29 and libav10 patches.

  [1] http://sources.debian.net/patches/libquicktime/2:1.2.4-8/
Comment 1 Ben Woods freebsd_committer freebsd_triage 2016-05-06 23:07:15 UTC 
Created attachment 170072 [details]
QA: Successful poudriere testport logs for multimedia/libquicktime with patch against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64
Comment 2 Ben Woods freebsd_committer freebsd_triage 2016-05-06 23:08:31 UTC 
Created attachment 170073 [details]
QA: Successful poudriere testport logs for multimedia/libquicktime with patch against FFmpeg 3.0.1 (from PR 207547) on FreeBSD 11-current amd64
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-05-07 17:23:19 UTC 
A commit references this bug:

Author: jbeich
Date: Sat May  7 17:22:22 UTC 2016
New revision: 414778
URL: https://svnweb.freebsd.org/changeset/ports/414778

Log:
  multimedia/libquicktime: unbreak build with ffmpeg 3.0

  lqt_ffmpeg.c:389:13: error: use of undeclared identifier 'CODEC_ID_MPEG1VIDEO'; did you mean 'AV_CODEC_ID_MPEG1VIDEO'?
        .id = CODEC_ID_MPEG1VIDEO,
              ^~~~~~~~~~~~~~~~~~~
  lqt_ffmpeg.c:547:13: error: use of undeclared identifier 'CODEC_ID_SVQ1'; did you mean 'AV_CODEC_ID_SVQ1'?
        .id = CODEC_ID_SVQ1,
              ^~~~~~~~~~~~~
  [...]

  PR:		209348
  Reported by:	antoine (via exp-run)
  Submitted by:	Ben Woods <woodsb02@gmail.com>
  Obtained from:	Debian

Changes:
  head/multimedia/libquicktime/Makefile
  head/multimedia/libquicktime/files/patch-ffmpeg2
  head/multimedia/libquicktime/files/patch-ffmpeg29
  head/multimedia/libquicktime/files/patch-libav10
Comment 4 Jan Beich freebsd_committer freebsd_triage 2016-05-07 17:23:56 UTC 
Thanks. Committed.