Summary: | shells/ksh93 does not build on ARM | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Ulrich Grey <usenet> | ||||||||
Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Some People | CC: | mikael | ||||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) |
||||||||
Version: | Latest | ||||||||||
Hardware: | arm | ||||||||||
OS: | Any | ||||||||||
Attachments: |
|
Description
Ulrich Grey
2016-05-11 17:52:27 UTC
Created attachment 170219 [details]
poudriere shells/ksh93 build log
It will build fine if you remove files/patch-src-lib-libast-hash-hashalloc.c and files/patch-src-lib-libast-string-tokscan.c Created attachment 170234 [details]
shells/ksh93 successful build on ARM log
After removing the mentioned patches the build finished successfully.
Now I try to compile CDE.
Thank you for advice.
Building CDE on ARM delivers this error: Building Release 2.2.3 of CDE ... make -f xmakefile VerifyOS Building on FreeBSD 11.0-CURRENT arm. make -f xmakefile Makefiles making Makefiles in config... ...skipping... 3 warnings and 3 errors generated. *** exit code 1 making cmdinit.o ksh93 requires libcmd but libcmd had build errors build libAST 930519 (In reply to Ulrich Grey from comment #4) Mikaƫl Urankar has provided some patches for building CDE. Applying these patches CDE builds well. There are no more errors. shells/ksh93 now works well for building CDE Desktop. Created attachment 176064 [details] armv6 fix Hi, Can we fix this issue? The problem was introduced in bug #185256 Using the upstream patch allows ksh93 to build on armv6 and 10.3/11.0 i386 see: https://github.com/att/ast/blob/beta/src/lib/libast/string/tokscan.c#L245 https://github.com/att/ast/blob/beta/src/lib/libast/hash/hashalloc.c#L154 thanks in advance. A commit references this bug: Author: sunpoet Date: Fri Oct 28 15:08:15 UTC 2016 New revision: 424858 URL: https://svnweb.freebsd.org/changeset/ports/424858 Log: - Fix build on armv6 - While I'm here, fix diff header of patch file PR: 209457 Submitted by: <mikael.urankar@gmail.com> Obtained from: https://github.com/att/ast/blob/beta/src/lib/libast/hash/hashalloc.c https://github.com/att/ast/blob/beta/src/lib/libast/string/tokscan.c Changes: head/shells/ksh93/files/patch-src-lib-libast-features-wchar head/shells/ksh93/files/patch-src-lib-libast-hash-hashalloc.c head/shells/ksh93/files/patch-src-lib-libast-string-tokscan.c Committed. Thanks! |