Bug 209482

Summary: security/nss: fails to build on arm
Product: Ports & Packages Reporter: Mikael Urankar <mikael>
Component: Individual Port(s)Assignee: freebsd-gecko (Nobody) <gecko>
Status: Closed FIXED    
Severity: Affects Many People CC: garga
Priority: ---    
Version: Latest   
Hardware: arm   
OS: Any   
Attachments:
Description Flags
armv6 fix
none
build log none

Description Mikael Urankar freebsd_committer freebsd_triage 2016-05-13 12:30:27 UTC 
Created attachment 170244 [details]
armv6 fix

Hi,
The port is broken on armv6:
http://beefy8.nyi.freebsd.org/data/head-armv6-default/p414461_s298930/logs/errors/nss-3.23.log

The attached patch fixes the problem
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2016-05-13 12:30:46 UTC 
Created attachment 170245 [details]
build log
Comment 2 Renato Botelho freebsd_committer freebsd_triage 2016-08-15 18:05:02 UTC 
I found the same issue on pfSense before seeing this issue, and I fixed it exactly the same way. Worked fine
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-09-25 18:03:58 UTC 
A commit references this bug:

Author: jbeich
Date: Sun Sep 25 18:03:05 UTC 2016
New revision: 422755
URL: https://svnweb.freebsd.org/changeset/ports/422755

Log:
  security/nss: unbreak build on armv6

  pqg.c:339:16: error: comparison of constant 18446744073709551615 with expression of type 'unsigned long' is always true [-Werror,-Wtautological-constant-out-of-range-compare]
      if (addend < MP_DIGIT_MAX) {
          ~~~~~~ ^ ~~~~~~~~~~~~
  1 error generated.

  PR:		209482
  Submitted by:	mikael.urankar@gmail.com (based on)

Changes:
  head/security/nss/files/patch-coreconf_FreeBSD.mk