Bug 209530

Summary: databases/soci: FIREBIRD_CMAKE_ARGS_ON -> FIREBIRD_CMAKE_ON
Product: Ports & Packages Reporter: Yuri Victorovich <yuri>
Component: Individual Port(s)Assignee: Julien Laffaye <jlaffaye>
Status: Closed FIXED    
Severity: Affects Only Me CC: adridg
Priority: --- Flags: bugzilla: maintainer-feedback? (jlaffaye)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Yuri Victorovich freebsd_committer freebsd_triage 2016-05-15 21:21:03 UTC 
Created attachment 170336 [details]
patch

{opt}_CMAKE_ARGS_ON isn't a valid syntax. Such variables are just ignored.
Comment 1 Adriaan de Groot freebsd_committer freebsd_triage 2017-10-12 12:03:51 UTC 
This still applies, and the port still ignores the option settings for Firebird because the CMake  arguments are not passed in correctly.
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-11-02 21:23:35 UTC 
A commit references this bug:

Author: adridg
Date: Thu Nov  2 21:22:39 UTC 2017
New revision: 453379
URL: https://svnweb.freebsd.org/changeset/ports/453379

Log:
  {opt}_CMAKE_ARGS_ON isn't a valid syntax. Use {opt}_CMAKE_ON instead.
  This makes the soci port obey the FIREBIRD option (otherwise it always
  looks for Firebird, even when you don't want it to).

  Submitted by yuri@ in PR 209530, maintainer timeout (17 months).

  PR:		209530
  Submitted by:	yuri@FreeBSD.org
  Reviewed by:	yuri (submitter)
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D12919

Changes:
  head/databases/soci/Makefile