Bug 209561

Summary: editors/kate: Fix build with libc++ 3.8.0
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Some People CC: pi
Priority: --- Flags: pi: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 208158    
Attachments:
Description Flags
Fix type for abs() call in editors/kate none

Description Dimitry Andric freebsd_committer 2016-05-16 21:23:46 UTC
Created attachment 170375 [details]
Fix type for abs() call in editors/kate

During the exp-run in bug 208158, it was found that editors/kate gives errors with libc++ 3.8.0 [1]:

/wrkdirs/usr/ports/editors/kate/work/kate-4.14.3/part/view/kateviewhelpers.cpp:1706:24: error: call to 'abs' is ambiguous
            int diff = abs(realLine - currentLine);
                       ^~~

This is because 'realLine' is int, and 'currentLine' is unsigned, making the whole expression unsigned.  Make 'currentLine' int to fix the problem.

[1] http://package18.nyi.freebsd.org/data/headamd64PR208158-default/2016-05-01_10h29m48s/logs/errors/kate-4.14.3_1.log
Comment 1 Kurt Jaeger freebsd_committer 2016-05-24 20:14:33 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2016-05-24 20:14:51 UTC
A commit references this bug:

Author: pi
Date: Tue May 24 20:14:19 UTC 2016
New revision: 415809
URL: https://svnweb.freebsd.org/changeset/ports/415809

Log:
  editors/kate: Fix build with libc++ 3.8.0

  PR:		209561
  Submitted by:	dim
  Approved by:	kde

Changes:
  head/editors/kate/files/patch-part_view_kateviewhelpers.cpp