Bug 20967

Summary: tx driver warns about unknown PHY
Product: Base System Reporter: Stefan Moeding <s.moeding>
Component: kernAssignee: semenu <semenu>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.1-STABLE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
tx.update.patch.gz none

Description Stefan Moeding 2000-08-31 18:10:01 UTC
The SMC 9432TX NIC is supported by the tx driver.  The card works like
a charm, only during startup the driver complains:

tx0: <SMC 83c170> port 0xe800-0xe8ff mem 0xe8001000-0xe8001fff irq 11 at device 10.0 on pci0
tx0: WARNING! PHY unknown (0x895): address 00:e0:29:6c:40:71, type SMC9432TX_2, Auto-Neg 100Mbps FD

Fix: 

In /usr/src/sys/kern/pci/if_tx.c around line 765:

/* Identify PHY */
sc->phyid = PHY_READ_2(sc, DP83840_PHYIDR1 )<<6;
sc->phyid|= (PHY_READ_2( sc, DP83840_PHYIDR2 )>>10)&0x3F;
if( QS6612_OUI != sc->phyid )
        printf(": WARNING! PHY unknown (0x%x)",sc->phyid);


Except for the printf there is nothing else happening, so it looks to
me as if this can either be removed completely or a second comparison
could be added to the if-expression.


Feel free to send patches for testing to me,
Stefan
Comment 1 Sheldon Hearn freebsd_committer freebsd_triage 2000-09-01 09:09:53 UTC
Responsible Changed
From-To: freebsd-bugs->semenu

Over to maintainer.
Comment 2 Semen Ustimenko 2000-09-07 17:57:11 UTC
Hi!

The right way to resolve this problem is to merge changes from current.
(As current code already support this PHY)

I have no 4.1 box here, so i ask you to test the update patch, it is
attached. New version use miibus, and can be built as KLD.
(So you have to add device miibus to kernel config, or remove device tx,
and build mii and tx KLD)

Good luck.
Comment 3 Stefan Moeding 2000-09-07 21:01:30 UTC
Hi!

Ustimenko Semen writes:

> The right way to resolve this problem is to merge changes from current.
> (As current code already support this PHY)

> I have no 4.1 box here, so i ask you to test the update patch, it is
> attached. New version use miibus, and can be built as KLD.
> (So you have to add device miibus to kernel config, or remove device tx,
> and build mii and tx KLD)

Your patch applied without any problems and ist working great.  
The output of dmesg looks like this:

tx0: <SMC EtherPower II 10/100> port 0x6000-0x60ff mem 0xe4001000-0xe4001fff irq 15 at device 17.0 on pci0
miibus0: <MII bus> on tx0
nsphy0: <AC101 10/100 media interface> on miibus0
nsphy0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto
tx0: address 00:e0:29:6c:40:53, type SMC9432TX_2

I could only test the static kernel, as there is no module available for
the tx driver.  There is no directory in /usr/src/sys/modules for the tx
driver in 4.1-STABLE.

OK, thanks for the patch,
Stefan
Comment 4 Semen Ustimenko 2000-09-08 01:58:25 UTC
On Thu, 7 Sep 2000, Stefan Moeding wrote:

> [skipped]
> Your patch applied without any problems and ist working great.  
> The output of dmesg looks like this:
> 
> tx0: <SMC EtherPower II 10/100> port 0x6000-0x60ff mem 0xe4001000-0xe4001fff irq 15 at device 17.0 on pci0
> miibus0: <MII bus> on tx0
> nsphy0: <AC101 10/100 media interface> on miibus0
> nsphy0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto
> tx0: address 00:e0:29:6c:40:53, type SMC9432TX_2
> 
> I could only test the static kernel, as there is no module available for
> the tx driver.  There is no directory in /usr/src/sys/modules for the tx
> driver in 4.1-STABLE.
> 
That dir should have been created by patch.

I'm glad it's woking, i'll commit same patch to RELENG_4 soon.

Bye!
Comment 5 semenu freebsd_committer freebsd_triage 2000-09-15 20:47:46 UTC
State Changed
From-To: open->closed

Merged from current new version supporting ALTIMA AC101 PHY.