Bug 209694

Summary:

x11-toolkits/wxgtk30: Fix build with libc++ 3.8.0

Product:

Ports & Packages

Reporter:

Dimitry Andric <dim>

Component:

Individual Port(s)

Assignee:

freebsd-ports-bugs (Nobody) <ports-bugs>

Status:

Closed FIXED

Severity:

Affects Some People

CC:

portmaster

Priority:

---

Keywords:

patch

Version:

Latest

Flags:

portmaster: maintainer-feedback+

Hardware:

Any

OS:

Any

Bug Depends on:

Bug Blocks:

208158

Attachments:

Description	Flags
Include <cmath> so abs(float) can be found	vlad-fbsd: maintainer-approval+

Description Dimitry Andric freebsd_committer

2016-05-22 11:46:49 UTC

Created attachment 170542 [details]
Include <cmath> so abs(float) can be found

During the exp-run in bug 208158, it was found that x11-toolkits/wxgtk30 gives errors with libc++ 3.8.0 [1]:

./src/stc/scintilla/src/Editor.cxx:5844:6: error: call to 'abs' is ambiguous
        if (abs(pt1.x - pt2.x) > 3)
            ^~~

This is because pt1.x and pt2.x are float values, but <cmath> is not included, and abs() for float values comes from that header.  Fix it by including <cmath>.

[1] http://package18.nyi.freebsd.org/data/headamd64PR208158-default/2016-05-01_10h29m48s/logs/errors/wx30-gtk2-3.0.2_4.log

Comment 1 Chris Hutchinson 2016-05-23 04:31:09 UTC

Comment on attachment 170542 [details]
Include <cmath> so abs(float) can be found

Makes sense.
Looks good,  Dimitry.

Thanks!

--Chris

Comment 2 VK 2016-05-23 07:29:29 UTC

Comment on attachment 170542 [details]
Include <cmath> so abs(float) can be found

Maintainer approved.

Comment 3 commit-hook freebsd_committer

2016-05-23 16:26:22 UTC

A commit references this bug:

Author: dim
Date: Mon May 23 16:25:21 UTC 2016
New revision: 415729
URL: https://svnweb.freebsd.org/changeset/ports/415729

Log:
  During the exp-run in bug 208158, it was found that x11-toolkits/wxgtk30
  gives errors with libc++ 3.8.0:

  ./src/stc/scintilla/src/Editor.cxx:5844:6: error: call to 'abs' is ambiguous
          if (abs(pt1.x - pt2.x) > 3)
              ^~~

  This is because pt1.x and pt2.x are float values, but <cmath> is not
  included, and abs() for float values comes from that header.  Fix it by
  including <cmath>.

  Approved by:	portmaster@bsdforge.com (maintainer)
  Approved by:	vlad-fbsd@acheronmedia.com (maintainer)
  PR:		209694
  MFH:		2016Q2

Changes:
  head/x11-toolkits/wxgtk30/files/patch-src_stc_scintilla_src_Editor.cxx