Bug 209705

Summary: x11/xbindkeys: take over MAINTAINER'ship
Product: Ports & Packages Reporter: Matthias Apitz <guru>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Some People CC: guru
Priority: --- Keywords: easy, patch, patch-ready
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch to change MAINTAINER in Makefile
none
patch to change MAINTAINER in Makefile none

Description Matthias Apitz 2016-05-23 05:45:31 UTC 
I'm using the port and could take it.
Comment 1 VK 2016-05-23 07:56:22 UTC 
Thanks. Please submit a patch against the latest SVN checkout. The MAINTAINER section of the Makefile needs to be set to your e-mail address. Please verify with portlint.

For more info please consult

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/

and

https://bitbucket.org/koobs/ports
Comment 2 Matthias Apitz 2016-05-23 08:59:36 UTC 
Created attachment 170561 [details]
patch to change MAINTAINER in Makefile



I did:

$ cd x11/xbindkeys
$ svn up

$ vi Makefile 
$ LANG=C svn diff Makefile
Index: Makefile
===================================================================
--- Makefile	(revision 415703)
+++ Makefile	(working copy)
@@ -7,7 +7,7 @@
 CATEGORIES=	x11
 MASTER_SITES=	http://www.nongnu.org/xbindkeys/
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	guru@unixarea.de
 COMMENT=	Allows you to launch shell commands under X with your keyboard
 
 LICENSE=	GPLv2

$ su
# make stage
# make check-orphans
# make package
# make install
# make deinstall
# pkg add package-filename

$ make package  # i.e. as normal user

$ portlint -cam


$ cd ..
$ shar `find xbindkeys` > xbindkeys.shar
Comment 3 VK 2016-05-23 09:46:45 UTC 
Comment on attachment 170561 [details]
patch to change MAINTAINER in Makefile

The attachment is a shar.
Comment 4 VK 2016-05-23 09:51:30 UTC 
Matthias, thanks. But you submitted a shar file which is for new ports. As you need to update existing, please cd to your ports tree root, then run `svn diff x11/xbindkeys > x11_xbindkeys.patch` and attach that patch here, obsolete the old one.
Comment 5 Matthias Apitz 2016-05-23 10:00:49 UTC 
(In reply to Vladimir Krstulja from comment #4)

I added both, the shar file and the 'svn diff' (see Comment #2);
Comment 6 Matthias Apitz 2016-05-23 10:11:34 UTC 
Created attachment 170564 [details]
patch to change MAINTAINER in Makefile
Comment 7 VK 2016-05-23 11:24:22 UTC 
Comment on attachment 170561 [details]
patch to change MAINTAINER in Makefile

Shar obsoleted by the new diff.
Comment 8 VK 2016-05-23 11:25:01 UTC 
Thanks.
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-05-23 15:18:12 UTC 
A commit references this bug:

Author: amdmi3
Date: Mon May 23 15:17:43 UTC 2016
New revision: 415724
URL: https://svnweb.freebsd.org/changeset/ports/415724

Log:
  - Pass maintainership to submitter
  - While here, minor cleanup
    - Clarify LICENSE
    - Add LICENSE_FILE
    - Remove unneeded flags
    - Don't needlessly and erroneously patch wish path when TCL is disabled and ${WISH} is not defined
    - Silence mkdir

  PR:		209705
  Submitted by:	guru@unixarea.de

Changes:
  head/x11/xbindkeys/Makefile