Bug 209717

Summary: audio/lxmusic: Update to 0.4.7
Product: Ports & Packages Reporter: ericturgeon
Component: Individual Port(s)Assignee: Olivier Duchateau <olivierd>
Status: Closed FIXED    
Severity: Affects Only Me CC: ericturgeon, olivierd
Priority: --- Keywords: needs-qa, patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
This is the shar file of the updated ports.
none
lxmusic ports diff from 0.4.5 to 0.4.7
none
lxmusic ports diff from 0.4.5 to 0.4.7
ericturgeon: maintainer-approval+
New patch for audio/lxmusic none

Description ericturgeon 2016-05-23 15:23:31 UTC
Created attachment 170572 [details]
This is the shar file of the updated ports.

I have notice that LXMusic got updated to 0.4.7 and I do want to add the updated ports. It is in the shar file attachment.
Comment 1 VK 2016-05-23 19:10:47 UTC
Thanks for the submission, but please supply a patch against the latest SVN tree. Shar files are only for new port submissions, not updates to existing. Please test, portlint, poudriere, and confirm it passes.
Comment 2 ericturgeon 2016-05-23 21:45:52 UTC
Created attachment 170581 [details]
lxmusic ports diff from 0.4.5 to 0.4.7
Comment 3 VK 2016-05-23 22:22:39 UTC
Thanks. Please reset or remove PORTREVISION. Also please mark the patch as maintainer approved, since you're the maintainer.
Comment 4 ericturgeon 2016-05-23 22:33:31 UTC
Created attachment 170582 [details]
lxmusic ports diff from 0.4.5 to 0.4.7

Ok this diff should be better.
Comment 5 Olivier Duchateau freebsd_committer freebsd_triage 2016-05-25 04:24:45 UTC
Created attachment 170645 [details]
New patch for audio/lxmusic

The previous patch is not good shape:

- %%NLS%% keywords are missing in pkg-plist
- USES= localbase now replace *FLAGS=
- In MASTER_SITES, it is advised do not hard-coded version
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-05-26 19:32:36 UTC
A commit references this bug:

Author: olivierd
Date: Thu May 26 19:32:16 UTC 2016
New revision: 415909
URL: https://svnweb.freebsd.org/changeset/ports/415909

Log:
  - Update to 0.4.7
  - Replace CPPFLAGS and LDFLAGS by USES= localbase
  - Cosmetic change for documentation
  - Fix build when NLS option is not set

  PR:		209717
  Submitted by:	<ericturgeon@ghostbsd.org> (maintainer)

Changes:
  head/audio/lxmusic/Makefile
  head/audio/lxmusic/distinfo
  head/audio/lxmusic/files/
  head/audio/lxmusic/files/patch-configure
  head/audio/lxmusic/pkg-plist
Comment 7 Olivier Duchateau freebsd_committer freebsd_triage 2016-05-26 19:33:49 UTC
Committed with minor changes, thanks!