Summary: | sysutils/3dm includes build hostname in pkg-message, makes package nonreproducible | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Ed Maste <emaste> | ||||
Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | pi, takefu | ||||
Priority: | --- | Flags: | pi:
maintainer-feedback+
|
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
URL: | https://reviews.freebsd.org/D6836 | ||||||
Attachments: |
|
Description
Ed Maste
2016-05-30 13:41:07 UTC
Mmm, poudriere has a BUILDER_HOSTNAME that sets the hostname to the jail as being the same for all jails, it's what's used to fix other ports that do the same things, sysutils/puppet comes to mind (it puts the hostname in the config file.) At least initially I don't want to set an option like that because I have a goal of determining the current state of package reproducibility. I also believe it is better to address these at the source rather than coerce system inputs to make builds reproducible; for this case BUILDER_HOSTNAME would address the nonreproducibility, but the message still might not be useful for a user of the package. 3dm is not redistributable so this won't affect official FreeBSD packages but would for someone building their own package set. Review at https://reviews.freebsd.org/D6836 Created attachment 171452 [details]
3dm-2.11.00.021_3,1.patch
Will also no problem to change from the hostname to localhost.
Simply it has inherited from #130295,
Not necessarily that particular stick.
I'm sorry too slow.
A commit references this bug: Author: pi Date: Mon Jun 27 19:29:07 UTC 2016 New revision: 417677 URL: https://svnweb.freebsd.org/changeset/ports/417677 Log: sysutils/3dm: fix hostname in pkg-message, make package reproducible PR: 209864 Reported by: emaste Submitted by: takefu@airport.fm (maintainer) Changes: head/sysutils/3dm/Makefile head/sysutils/3dm/distinfo head/sysutils/3dm/files/pkg-message.in head/sysutils/3dm/pkg-descr Committed, thanks |