Summary: | www/gitlab: update to 8.8.2 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Torsten Zühlsdorff <ports> | ||||||
Component: | Individual Port(s) | Assignee: | Torsten Zuehlsdorff <tz> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | pi, ports, ruby, tz | ||||||
Priority: | --- | Keywords: | needs-qa, patch | ||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209815 | ||||||||
Bug Depends on: | 208693, 209899, 209900, 209901, 209902 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Thanks for the patch, Thorsten. Could you please set maintainer-approval+ on it, since you're the maintainer, it will appear in the "Maintainer approved" saved search in Bugzilla, which helps speed up resolving the issue. ;) Hello Vladimir, this time i did not set it with purpose. :) I'm currently in testing this patch and will set the flag when i finished it. Greetings, Torsten Thorsten, thanks for the heads up. ;) My apologies for misspelling your name, twice now, Torsten. No disrespect intended. No offense taken, Vladimir. It is quite common to misspell my name, especially my lastname (especially in international communication). I know you addressed me and this is what matters. :) BTW: names are a general hot topic of problems. If i take your name for example it is quite common to write it "Vladimir". In Germany we would most likley write it in another way: "Wladimir". And i'm personally confused every time, since my russian lessons taught me to write Владимир. Because of this i copy the name of every participant i talk to and hope i did not misspell his own name (which happens) :D I'm build-testing on a loaded 11 host with ruby=2.3. This comes up: ===> rubygem-devise-rails4-3.5.6 is marked as broken: does not build with Ruby 2.3. I checked and devel/rubygem-devise is at 4.1.1 already. Would updating fix that BROKEN ? Testbuild in poudriere looks like some of PRs are depends, not blocks: cur [00:00:09] ====>> Error: Nonexistent port listed for build: converters/rubygem-base32 --> 209901 is depend, not block [00:00:11] ====>> Error: Nonexistent port listed for build: devel/rubygem-health_check --> 209902 is depend, not block (In reply to Kurt Jaeger from comment #7) > I checked and devel/rubygem-devise is at 4.1.1 already. > Would updating fix that BROKEN ? I don't think so. Currently there is no Ruby 2.3 support for GitLab :( Maybe i should add an IGNORE line or similar to make this clear? > Testbuild in poudriere looks like some of PRs are depends, not blocks: Yes. All of the PRs are depends, not blocks. Fixed this! Created attachment 171613 [details]
path with update to 8.8.5
Revised patch with update to new version 8.8.5
A commit references this bug: Author: tz Date: Tue Jun 21 08:36:57 UTC 2016 New revision: 417194 URL: https://svnweb.freebsd.org/changeset/ports/417194 Log: www/gitlab: Update from 8.7.5 to 8.8.5 Changelog: https://github.com/gitlabhq/gitlabhq/blob/8-8-stable/CHANGELOG PR: 209903 Approved by: swills (mentor) Changes: head/www/gitlab/Makefile head/www/gitlab/distinfo head/www/gitlab/files/gitlab.in head/www/gitlab/files/patch-Gemfile head/www/gitlab/files/patch-config_gitlab.yml.example head/www/gitlab/files/patch-config_initializers_1__settings.rb head/www/gitlab/files/patch-lib_support_nginx_gitlab head/www/gitlab/files/patch-lib_support_nginx_gitlab-ssl head/www/gitlab/pkg-plist Committed! Thanks to all the supporters! :) |
Created attachment 170881 [details] patch with update to 8.8.2 Hello, attached a patch to bring the port to its current version. Buildtests are fine for 9.3, 10.0, 10.2 and 10.3 amd64 and i386. portlint is also fine. I also did a short runtime test. Beside the update itself i now remove all gitignore files, because 8.8.2 ships a greater number of them. I also integrated the needed config fix out of #208693 for the port itself and tried to fix #209815 also. I'm still in the testing phase but wand to give the possibility to test to others. Greetings, Torsten