Bug 209941
| Summary: | [NEW PORT] sysutils/bsdisks: UDisks2 service implementation for FreeBSD | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Gleb Popov <arrowd> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | Keywords: | feature, needs-qa, patch | ||||||||||||
| Priority: | --- | ||||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
Hello, thanks for the port submission. However, can you please submit a shar file? For more information please consult: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-submitting.html Also please confirm the port tests fine with portlint and, for example, porttools' port test or poudriere. Created attachment 170930 [details]
The shar archive with port
Also you shouldn't use LICENSE=BSD (this is actually BSD3CLAUSE) and you should use USE_QT5 instead of *_DEPENDS for qt5 depends. Also it does not build:
-- Detecting CXX compile features - done
CMake Error at /usr/local/lib/cmake/Qt5Core/Qt5CoreConfig.cmake:15 (message):
The imported target "Qt5::Core" references the file
"/usr/local/lib/qt5/bin/qmake"
but this file does not exist. Possible reasons include:
* The file was deleted, renamed, or moved to another location.
* An install or uninstall procedure did not complete successfully.
* The installation package was faulty and contained
"/usr/local/lib/cmake/Qt5Core/Qt5CoreConfigExtras.cmake"
but not all the files it references.
Call Stack (most recent call first):
/usr/local/lib/cmake/Qt5Core/Qt5CoreConfigExtras.cmake:6 (_qt5_Core_check_file_exists)
/usr/local/lib/cmake/Qt5Core/Qt5CoreConfig.cmake:146 (include)
CMakeLists.txt:8 (find_package)
-- Configuring incomplete, errors occurred!
See also "/wrkdirs/usr/ports/sysutils/bsdisks/work/bsdisks-0.2/CMakeFiles/CMakeOutput.log".
*** Error code 1
Created attachment 171266 [details]
The shar archive with port
Addressed comments, hopefully fix build error.
Created attachment 171639 [details]
The shar archive with port
Updated port. Fixed build issues on 10-STABLE and 11-CURRENT.
Fails to build on 9.x:
/wrkdirs/usr/ports/sysutils/bsdisks/work/bsdisks-0.2/filesystemprober.cpp:35:17: error: chosen constructor is explicit in copy-initialization
QStringList args = {m_dev};
^ ~~~~~~~
/usr/local/include/qt5/QtCore/qstringlist.h:98:21: note: constructor declared here
inline explicit QStringList(const QString &i) { append(i); }
^
1 error generated.
Created attachment 171707 [details]
Shar archive with the port
Fix build on 9.3-RELEASE.
A commit references this bug: Author: amdmi3 Date: Thu Jun 23 11:45:41 UTC 2016 New revision: 417365 URL: https://svnweb.freebsd.org/changeset/ports/417365 Log: - Add sysutils/bsdisks UDisks2 service provides interfaces to enumerate and perform operations on disks and storage devices via D-Bus API. Bsdisks is an implementation of UDisks2 service for FreeBSD. WWW: http://bitbucket.org/arrowd/bsdisks PR: 209941 Submitted by: 6yearold@gmail.com Changes: head/sysutils/Makefile head/sysutils/bsdisks/ head/sysutils/bsdisks/Makefile head/sysutils/bsdisks/distinfo head/sysutils/bsdisks/files/ head/sysutils/bsdisks/files/patch-11-current head/sysutils/bsdisks/files/patch-93-release head/sysutils/bsdisks/pkg-descr head/sysutils/bsdisks/pkg-plist Thumbs up! |
Created attachment 170921 [details] The archive with port This is a port for UDisks2 daemon implementation for FreeBSD.