Bug 209967

Summary: [PATCH] net-im/libqtelegram-ae, net-im/telegramqml, net-im/cutegram: Fix build with libc++ 3.8.0
Product: Ports & Packages Reporter: Guido Falsi <madpilot>
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Some People CC: henry.hu.sh
Priority: --- Keywords: patch
Version: LatestFlags: henry.hu.sh: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch henry.hu.sh: maintainer-approval+

Description Guido Falsi freebsd_committer freebsd_triage 2016-06-02 11:08:33 UTC
Created attachment 170945 [details]
patch

Hi,

ON FreeBSD head, which will become FreeBSD 11.0 in the near future, the libc++ component has been updated to version 3.8.0.

I have noticed the cutegram ports fail to compile with it due to a problem in the include directories ordering. It is inappropriately using the compile -isystem flag.

I have tested the attached fix, can you review and approve this?

While here I also added the USE_OPENSSL=yes directive to the ports, since they actually link against that. I should have noticed this when first adding these ports to the tree.

Thanks!
Comment 1 Henry Hu 2016-06-18 17:51:23 UTC
I've tested it using poudriere and it's ok.
The patch seems fine.
Please commit it. Thanks.
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-06-18 22:11:41 UTC
A commit references this bug:

Author: madpilot
Date: Sat Jun 18 22:10:55 UTC 2016
New revision: 417093
URL: https://svnweb.freebsd.org/changeset/ports/417093

Log:
  Fix build with libc++ 3.8.0.

  PR:		209967
  Submitted by:	me
  Approved by:	Henry Hu <henry.hu.sh at gmail.com> (maintainer)

Changes:
  head/net-im/cutegram/Makefile
  head/net-im/libqtelegram-ae/Makefile
  head/net-im/telegramqml/Makefile
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2016-06-18 22:15:48 UTC
Committed. Thanks!