Summary: | sysutils/slurm-wlm: upgrade to 15.08.12 and fix dependency issue | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Joseph Mingrone <jrm> | ||||||
Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | Keywords: | easy, patch | ||||||
Priority: | --- | Flags: | jrm:
maintainer-feedback+
|
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Joseph Mingrone
2016-06-03 14:29:18 UTC
- It's better to place each dependency on a separate line, otherwise it's easy to miss. - Fixed two more bogus variable names A commit references this bug: Author: amdmi3 Date: Fri Jun 3 19:31:13 UTC 2016 New revision: 416333 URL: https://svnweb.freebsd.org/changeset/ports/416333 Log: - Update to 15.08.12 - Fix dependencies PR: 209996 Submitted by: jrm@ftfl.ca (maintainer) Changes: head/sysutils/slurm-wlm/Makefile head/sysutils/slurm-wlm/distinfo Created attachment 170992 [details]
svn patch to fix linking issues
Thanks for your sharp eyes detecting those variable issues.
I did more testing in poudriere and saw the errors below. This patch corrects those issues and bumps PORTREVISION. It also modernizes the MYSQL option (MYSQL_USES=mysql).
Error: /usr/local/bin/sview is linked to /usr/local/lib/libcairo.so.2 from graphics/cairo but it is not declared as a dependency
Warning: you need USE_GNOME+=cairo
Error: /usr/local/bin/sview is linked to /usr/local/lib/libgdk_pixbuf-2.0.so.0 from graphics/gdk-pixbuf2 but it is not declared as a dependency
Warning: you need USE_GNOME+=gdkpixbuf2
Error: /usr/local/bin/sview is linked to /usr/local/lib/libfontconfig.so.1 from x11-fonts/fontconfig but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libfontconfig.so:x11-fonts/fontconfig
Error: /usr/local/bin/sview is linked to /usr/local/lib/libfreetype.so.6 from print/freetype2 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libfreetype.so:print/freetype2
Error: /usr/local/bin/sview is linked to /usr/local/lib/libintl.so.8 from devel/gettext-runtime but it is not declared as a dependency
Warning: you need USES+=gettext
These are bogus, please ignore them. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209813 However, while I see depends for GTK2 and MYSQL, I don't see anything which tells configure to actually enable/disable these (like _CONFIGURE_WITH). This may lead to ghost dependencies (e.g. when port is built with GTK2 disabled, though gtk2 is installed on the system, configure detects and enables it -> we get uncounted dependency and the port breaks when gtk2 is removed). If that's true, it requires fixing. Ok, thanks. I had a long conversation with upstream about this exact topic. For many of the plugins they don't have an explicit on/off autoconf switch, but rely on auto detection. So, *if* GTK is installed, then the build sview (GUI interface). I explained why this is not ideal, especially for package building, and it sounds like they are open to fixing this. Good. For the time being though, it would be nice to provide a workaround. configure scripts are usually hackable, for example something like post-patch-GTK2-off: @${REINPLACE_CMD} -e 's|ac_gtk_test="yes"|ac_gtk_test="no"|' ${WRKSRC}/configure may work. Same for ac_have_mysql, or --with-mysql_config=/nonexistent |